Fix: transaction has itself as a parent which causes deadloop on closing

[verity1886]

…

Fi for mentioned issue where transaction has itself as a parent transaction which causes deadloop on closing

Description (*)

getParentId()

Fixed Issues (if relevant)

1. Fixes Transaction parent-child relationship inconsistent under details view. #39999

Manual testing scenarios (*)

1. On the frontend, create an order and complete payment using an Auth transaction.
2. In the Admin panel navigated to Sales > Orders
3. Select the order from Step 1
4. Open the Invoice tab and click Capture Online [Submit Invoice].
5. Navigate to Transactions from the left menu to view the transaction summary table.
6. Click on a transaction to view its details.

Questions or comments

But the issue i personally faced is when the payment requires authentication (with 3Ds, for example), order is already placed and payment tries to update the transaction to close it, causing the deadloop as it tries to cloase the parent transaction firstly (which is actually is the current transaction)

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @verity1886. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[ct-prd-pr-scan]

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].