Skip to content

Patches are not removed after the module uninstallation #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop-2.4
Choose a base branch
from
Open

Patches are not removed after the module uninstallation #2170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Setup/Patch/Data/Migrate24.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
use Magento\Framework\Setup\ModuleDataSetupInterface;
use Magento\Framework\Setup\Patch\DataPatchInterface;
use Magento\Framework\Setup\Patch\PatchVersionInterface;
use Magento\Framework\Setup\Patch\PatchRevertableInterface;

class Migrate24 implements DataPatchInterface, PatchVersionInterface
class Migrate24 implements DataPatchInterface, PatchVersionInterface, PatchRevertableInterface
{
/**
* @var ModuleDataSetupInterface
Expand Down Expand Up @@ -51,5 +52,16 @@ public static function getVersion()
{
return '1.0.24';
}

/**
* Revert data changes
*
* @return bool
*/
public function revert()
{
return true;
}

}

14 changes: 13 additions & 1 deletion Setup/Patch/Data/Migrate32.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
use Magento\Framework\Setup\Patch\DataPatchInterface;
use Magento\Framework\Setup\Patch\PatchVersionInterface;
use Ebizmarts\MailChimp\Model\ResourceModel\MailChimpWebhookRequest\CollectionFactory;
use Magento\Framework\Setup\Patch\PatchRevertableInterface;

class Migrate32 implements DataPatchInterface, PatchVersionInterface
class Migrate32 implements DataPatchInterface, PatchVersionInterface, PatchRevertableInterface
{
/**
* @var ModuleDataSetupInterface
Expand Down Expand Up @@ -90,5 +91,16 @@ public static function getVersion()
{
return '1.2.32';
}

/**
* Revert data changes
*
* @return bool
*/
public function revert()
{
return true;
}

}

14 changes: 13 additions & 1 deletion Setup/Patch/Data/Migrate35.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
use Magento\Framework\Setup\Patch\DataPatchInterface;
use Magento\Framework\Setup\Patch\PatchVersionInterface;
use Magento\Config\Model\ResourceModel\Config\Data\CollectionFactory as ConfigFactory;
use Magento\Framework\Setup\Patch\PatchRevertableInterface;

class Migrate35 implements DataPatchInterface, PatchVersionInterface
class Migrate35 implements DataPatchInterface, PatchVersionInterface, PatchRevertableInterface
{
/**
* @var ModuleDataSetupInterface
Expand Down Expand Up @@ -79,5 +80,16 @@ public static function getVersion()
{
return '102.3.35';
}

/**
* Revert data changes
*
* @return bool
*/
public function revert()
{
return true;
}

}