🔨 Remove usage of internal sklearn.utils api, replace with equivalent #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: "Pull request"
about: Make changes in scikit-uplift
📑 Description of the Change
I was trying to use this library with the modern version of sklearn in which they moved function
check_matplotlib_supportto the_optional_dependenciesfolder which looks like an internal one and thus can be moved again later. To properly solve this, I copied the implementation of this function to our utils.Verification Process
I tested a new version of library in my project and also checked it in existing tests.
Release Notes
sklearn.utils.check_matplotlib_supportapi and replace with equivalent