Skip to content

Conversation

@s2mr
Copy link

@s2mr s2mr commented May 9, 2023

When using the latest swiftlint 0.51.0, xcodeproj's prebuild script occurs a fatal error.
So, the build failed for users who use carthage and install the latest swiftlint.

And, xcodeproj file contains missing reference files. So I deleted it.

This PR contains the following:

  • Fix swiftlint serious violations.
  • Delete missing reference in xcodeproj
  • Equal xcodeproj's ios minimum development target to Package.swift

Environment:

  • carthage 0.39.0
  • swiftlint 0.51.0
  • Xcode 14.2.0
  • Mac OS Ventura 13.2.1(22D68)

case Calendar.Identifier.persian.description: self = .persian
case Calendar.Identifier.republicOfChina.description: self = .republicOfChina
case Calendar.Identifier.islamicTabular.description: self = .islamicTabular
case Calendar.Identifier.islamicTabular.description: self = .islamicTabular
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case is duplicated.

Copy link

@lpbas lpbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good!

Any plans on merging this? SwiftDate 7.0.0 won't install when using tuist for our project due to the Project file's missing files, and this could be the solution.

Copy link

@mmackowiak mmackowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@ddanielczyk
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants