Update repeater.go, fix for #16 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have the same issue, and my screen reader is needed for an automation tool, so I can't disable it. With this code. I have tested it works for after the change. PS: The code is done w/ Copilot's help.
|
Thanks, looks good! Could you please add a test as well? wsl2-ssh-agent/repeater_test.go Line 19 in b82a602 It would be good enough to change |
|
@mame , strange enough, I had some issue running the tests locally. The last case had a few exceptions when I run on my laptop. I prepared a change as you suggested. Let me know if you'd like to make any updates. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have the same issue, and my screen reader is needed for an automation tool, so I can't disable it. With this code. I have tested it works for after the change.
PS: The code is done w/ Copilot's help.