-
Notifications
You must be signed in to change notification settings - Fork 2.2k
softlist: splitted programmer into multiple entries #14146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
If you have no idea what to read before go to sleep, that would be ideal candidate. |
963221d
to
bc857ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some that weren’t fully split, and some that were dubious to begin with.
There seems to be a general issue with the 4am stuff that it’s just based on the credits, and everyone credited has been dumped in as a “programmer”, including writers, artists, producers, etc. Also, uncredited programmers are not listed, even in cases where they’re well known.
hash/mac_flop_orig.xml
Outdated
<info name="programmer" value="Gregory Simons, Scott Levy, Mark Jeffery, and Mei-Ying C. Dell'Aquila" /> | ||
<info name="programmer" value="Gregory Simons" /> | ||
<info name="programmer" value="Scott Levy" /> | ||
<info name="programmer" value="Mark Jeffery" /> | ||
<info name="programmer" value="Mei-Ying C. Dell'Aquila" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but was Mei-Ying C. Dell’Aquila actually a programmer? I know they did artwork/graphics/animation for multiple Apple IIgs and Macintosh games, but I don’t think they were actually a programmer.
For this game specifically, I think Gregory Simons was the only programmer, Scott Levy was the level designer, and Mark Jeffery and Mei-Ying C. Dell’Aquila were artists.
Do some of these programmer
info elements for 4am games just have all the people listed in the credits dumped into them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been adding everyone or mostly everyone in the credits. If we should be limiting to only programmers, I can do that, but we should have options for artists and such. A-Noid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just rename "programmer" to "developer"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me complete the split and then we can work on correcting meta after. I'm planning to preserve Vas' suspicious in comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just rename "programmer" to "developer"?
I've been using company names for developer, when a company develops it and doesn't list the programmers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like "publisher" is more suitable for this case, but needs conclusion from others.
hash/mac_flop_orig.xml
Outdated
<info name="programmer" value="Gregory Simons and Mei-Ying Dell'Aquila" /> | ||
<info name="programmer" value="Gregory Simons" /> | ||
<info name="programmer" value="Mei-Ying Dell'Aquila" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m guessing people are listed how they’re credited in the game itself, but if different variants of a name are used it makes filtering a bit more cumbersome (also another game that seems to list an artist as a “programmer” in the software list.
hash/apple2gs_flop_misc.xml
Outdated
<info name="programmer" value="Roberta Williams, Jeff Stephenson, Chris Iden, Robert Heitman, Ken Williams, Sol Ackerman, Scott Murphy, Doug MacNeill, Mark Crowe, and Al Lowe" /> | ||
<info name="programmer" value="Roberta Williams" /> | ||
<info name="programmer" value="Jeff Stephenson" /> | ||
<info name="programmer" value="Chris Iden" /> | ||
<info name="programmer" value="Robert Heitman" /> | ||
<info name="programmer" value="Ken Williams" /> | ||
<info name="programmer" value="Sol Ackerman" /> | ||
<info name="programmer" value="Scott Murphy" /> | ||
<info name="programmer" value="Doug MacNeill" /> | ||
<info name="programmer" value="Mark Crowe" /> | ||
<info name="programmer" value="Al Lowe" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like another case of calling everyone credited a “programmer” – Roberta Williams was a writer, not a programmer (and I think Al Lowe was as well).
hash/apple2gs_flop_clcracked.xml
Outdated
<info name="programmer" value="Marek Jackiewicz, Andrzej Miciłkiewicz, Marcin Szostakowski, Maciej Markuszewski, and Dorota Błaszczak" /> | ||
<info name="programmer" value="Marek Jackiewicz" /> | ||
<info name="programmer" value="Andrzej Miciłkiewicz, Marcin Szostakowski, Maciej Markuszewski, and Dorota Błaszczak" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one wasn’t fully split? Confused by Polish surnames?
hash/apple2gs_flop_clcracked.xml
Outdated
<info name="programmer" value="Marek Jackiewicz, Andrzej Miciłkiewicz, Marcin Szostakowski, Maciej Markuszewski, and Dorota Błaszczak" /> | ||
<info name="programmer" value="Marek Jackiewicz" /> | ||
<info name="programmer" value="Andrzej Miciłkiewicz, Marcin Szostakowski, Maciej Markuszewski, and Dorota Błaszczak" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More Polish names not separated. I think it only happens when “ł” is in a name before the last one.
hash/apple2_flop_orig.xml
Outdated
<info name="programmer" value="Cary Hammer, Alissa Ossip, Donald Way, Jo Ann Comito, Stuart Blavatnik, Amy E. McKinley, Rose Trivisonno, Lisa Feder-Feitel, Lisa Mandel, Maureen Stapleton, Jessica Stonier, and Tara Framer" /> | ||
<info name="programmer" value="Cary Hammer" /> | ||
<info name="programmer" value="Alissa Ossip" /> | ||
<info name="programmer" value="Donald Way" /> | ||
<info name="programmer" value="Jo Ann Comito" /> | ||
<info name="programmer" value="Stuart Blavatnik" /> | ||
<info name="programmer" value="Amy E. McKinley" /> | ||
<info name="programmer" value="Rose Trivisonno" /> | ||
<info name="programmer" value="Lisa Feder-Feitel, Lisa Mandel, Maureen Stapleton, Jessica Stonier, and Tara Framer" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another similar one.
hash/apple2_flop_orig.xml
Outdated
<info name="programmer" value="Cary Hammer, Alissa Ossip, Donald Way, Jo Ann Comito, Stuart Blavatnik, Rose Trivisonno, Lisa Feder-Feitel, Lisa Mandel, Maureen Stapleton, Jessica Stonier, and Tara Framer" /> | ||
<info name="programmer" value="Cary Hammer" /> | ||
<info name="programmer" value="Alissa Ossip" /> | ||
<info name="programmer" value="Donald Way" /> | ||
<info name="programmer" value="Jo Ann Comito" /> | ||
<info name="programmer" value="Stuart Blavatnik" /> | ||
<info name="programmer" value="Rose Trivisonno" /> | ||
<info name="programmer" value="Lisa Feder-Feitel, Lisa Mandel, Maureen Stapleton, Jessica Stonier, and Tara Framer" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next in the block of similar ones.
hash/apple2_flop_orig.xml
Outdated
<info name="programmer" value="Cary Hammer, Alissa Ossip, Donald Way, Jo Ann Comito, Stuart Blavatnik, Rose Trivisonno, Lisa Feder-Feitel, Lisa Mandel, Jessica Stonier, and Tara Framer" /> | ||
<info name="programmer" value="Cary Hammer" /> | ||
<info name="programmer" value="Alissa Ossip" /> | ||
<info name="programmer" value="Donald Way" /> | ||
<info name="programmer" value="Jo Ann Comito" /> | ||
<info name="programmer" value="Stuart Blavatnik" /> | ||
<info name="programmer" value="Rose Trivisonno" /> | ||
<info name="programmer" value="Lisa Feder-Feitel, Lisa Mandel, Jessica Stonier, and Tara Framer" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the last similar one in this block.
hash/apple2_flop_orig.xml
Outdated
<info name="programmer" value=" D. A. Decker, Jr." /> | ||
<info name="programmer" value="D. A. Decker Jr." /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lost its comma.
hash/apple2_flop_orig.xml
Outdated
<info name="programmer" value="Chuck Sommerville, John Leupp, Kevin Norman, Larry Clague, and Scott Nelson; ported to the Apple ][ by John Stouffer, Jeff Webb, Doug Matson, Greg Broniak, Tim Grost, Matt Decker, Vera Petrusha, Ken Evans, Dr. Keith Dreyer, and Chris Oesterling" /> | ||
<info name="programmer" value="Chuck Sommerville" /> | ||
<info name="programmer" value="John Leupp" /> | ||
<info name="programmer" value="Kevin Norman" /> | ||
<info name="programmer" value="Larry Clague" /> | ||
<info name="programmer" value="Scott Nelson; ported to the Apple ][ by John Stouffer, Jeff Webb, Doug Matson, Greg Broniak, Tim Grost, Matt Decker, Vera Petrusha, Ken Evans, Dr. Keith Dreyer, and Chris Oesterling" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another one that totally confused it.
I think it's in a better shape now. |
It sounds reasonable to change programmer -> developer, but I noticed entries where we currently have both. |
@@ -24710,6 +24710,7 @@ license:CC0-1.0 | |||
<year>1985</year> | |||
<publisher>Electronic Arts</publisher> | |||
<info name="alt_title" value="Tales of the Unknown: The Bard's Tale" /> | |||
<info name="language" value="French" /> | |||
<info name="developer" value="Interplay Productions" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. here
@@ -25554,6 +25555,7 @@ license:CC0-1.0 | |||
<description>Magic Spells (version 1981) (Apple)</description> | |||
<year>1981</year> | |||
<publisher>Apple Computer</publisher> | |||
<info name="original_publisher" value="Advanced Learning Technology" /> | |||
<info name="developer" value="Advanced Learning Technology"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more
No description provided.