Skip to content

Install json_reader target #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 15, 2025
Merged

Install json_reader target #561

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09da14b
Install json_reader target
Hind-M Sep 11, 2025
131107d
Add alias of nlohmann_json target
Hind-M Sep 11, 2025
208cd69
Link on condition
Hind-M Sep 11, 2025
3a7508e
Add imported condition
Hind-M Sep 12, 2025
92b1a9c
Test same target name
Hind-M Sep 12, 2025
1acd5ef
Clean up
Hind-M Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,21 @@ include(GNUInstallDirs)
include(CMakePackageConfigHelpers)

# Install target
install(TARGETS sparrow
set(SPARROW_EXPORTED_TARGETS sparrow)

if(CREATE_JSON_READER_TARGET)
list(APPEND SPARROW_EXPORTED_TARGETS json_reader)
if(TARGET nlohmann_json)
get_target_property(is_imported nlohmann_json IMPORTED)
if(NOT is_imported)
# This means `nlohmann_json` was fetched using FetchContent
# We need to export `nlohmann_json` target explicitly
list(APPEND SPARROW_EXPORTED_TARGETS nlohmann_json)
endif()
endif()
endif()

install(TARGETS ${SPARROW_EXPORTED_TARGETS}
EXPORT ${PROJECT_NAME}-targets)

# Makes the project importable from the build directory
Expand Down
Loading