feat: add parseLatLng and sexagesimal options #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds two options:
- parseLatLng (which default to `parseFloat`), allowing to take control
on how the lat and lng text values will be parsed
- sexagesimal (default=true), which allow to skip the sexagesimal parsing
(when false), as it wrongly parses a French number ("1,234" will become 1)
In uMap, we are sometimes in the need to parse CSV files where
lat/lng values are in French number format (with "," as separator, instead of
".").
For a bit more context: gristlabs/grist-core#992
|
Hey, is this feature unwanted or this repo missing for maintainers ? If it's the later, we could do the job with the uMap team, as we use this lib. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two options:
parseFloat), allowing to take control on how the lat and lng text values will be parsedIn uMap, we are sometimes in the need to parse CSV files where lat/lng values are in French number format (with "," as separator, instead of ".").
For a bit more context: gristlabs/grist-core#992
Thanks! :)