Update Test Framework to handle SQL Exception when extracting rows fr… #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Abhishek, can you review this change? Thanks. --Robert |
|
Hey Robert, sorry this is taking time. Will shortly spend some time on this. |
agirish
approved these changes
Nov 2, 2018
|
@rhou1 just a gentle reminder. Let me know if you are confident on getting this merged in (no issues with tests and such) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…om resultSet.
This will catch the SQL errors generated by the new negative Decimal tests.
Chun, please review this change.
Test Framework runs:
http://10.10.104.91:8080/job/Test_Framework_Functional_Tests/231/console
http://10.10.104.91:8080/job/Test_Framework_Advanced_Tests/204/console