Fix: TS types for DataMapOptions.fills #500
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delapuente
added a commit
to qiskit-community/community.qiskit.org
that referenced
this pull request
Sep 5, 2019
--- New software version notes: This commit updates to Nuxt 2.9.2. The new version has some implications when coming from 2.8.X version using Typescript: https://typescript.nuxtjs.org/migration.html Due to this bug: markmarkoh/datamaps#500 A custom version of datamaps is used for rendering the Advocate Map: https://github.com/delapuente/datamaps/tree/fix-types --- The new theme makes extensive use of dark and electric colors with a vibrant header, combining different styles of sections with ad-hoc widgets to showcase the capabilities of the design. Affected pages are `/education` and `/advocates`. The new design integrates with qiskit.org by faking the top menu and adding an internal community sub-menu. It also adds a footer with Qiskit elements, community sub-sections and social media. This commit adds a new component structure aimed at creating a collection of highly composable units. These units use BEM for internal styling. It is recommended not to style the components outside their physical boundaries to give the page freedom to integrates. However, the CSS framework (which is now SCSS) provide a collection of mixin for standarizing the layout. The point of entry for the community is redirecting to the education micro-site on purpose. This commit intentionally breaks the separation between design and presentation. A better approach is needed to allow content documents to be able of providing several HTML sections instead of only one. A summary of the problem can be found at: https://michaelnthiessen.com/advanced-vue-controlling-parent-slots The most semantic solution, [portals](https://github.com/LinusBorg/portal-vue), don't work in server-side rendering mode and so, the portals are not populated with content in a static-site configuration. We are exploring embedding multiple front-matter documents at: https://github.com/delapuente/frontmatter-markdown-loader/tree/multiple The other solutions also rely on client reactivity which is not the desired behaviour. The new design also intentionally avoids the use of the `<nuxt-link>` component. Due to unknown reasons, DOM differentiation does not work correctly and the navigation is ultimately broken. Follow-ups for solving the navigation issues, improve reactivity in secondary content and recover the separation between design and content are filled in the project repository.
|
Are there plans for merging this? |
y4izus
pushed a commit
to y4izus/qiskit.org
that referenced
this pull request
Nov 11, 2020
--- New software version notes: This commit updates to Nuxt 2.9.2. The new version has some implications when coming from 2.8.X version using Typescript: https://typescript.nuxtjs.org/migration.html Due to this bug: markmarkoh/datamaps#500 A custom version of datamaps is used for rendering the Advocate Map: https://github.com/delapuente/datamaps/tree/fix-types --- The new theme makes extensive use of dark and electric colors with a vibrant header, combining different styles of sections with ad-hoc widgets to showcase the capabilities of the design. Affected pages are `/education` and `/advocates`. The new design integrates with qiskit.org by faking the top menu and adding an internal community sub-menu. It also adds a footer with Qiskit elements, community sub-sections and social media. This commit adds a new component structure aimed at creating a collection of highly composable units. These units use BEM for internal styling. It is recommended not to style the components outside their physical boundaries to give the page freedom to integrates. However, the CSS framework (which is now SCSS) provide a collection of mixin for standarizing the layout. The point of entry for the community is redirecting to the education micro-site on purpose. This commit intentionally breaks the separation between design and presentation. A better approach is needed to allow content documents to be able of providing several HTML sections instead of only one. A summary of the problem can be found at: https://michaelnthiessen.com/advanced-vue-controlling-parent-slots The most semantic solution, [portals](https://github.com/LinusBorg/portal-vue), don't work in server-side rendering mode and so, the portals are not populated with content in a static-site configuration. We are exploring embedding multiple front-matter documents at: https://github.com/delapuente/frontmatter-markdown-loader/tree/multiple The other solutions also rely on client reactivity which is not the desired behaviour. The new design also intentionally avoids the use of the `<nuxt-link>` component. Due to unknown reasons, DOM differentiation does not work correctly and the navigation is ultimately broken. Follow-ups for solving the navigation issues, improve reactivity in secondary content and recover the separation between design and content are filled in the project repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in type definitions of
DataMapOptions.fillswithIndex signatures.I encountered it in VueJS + Typescript project.
More explanation here, section
Excluding certain properties from the index signaturehttps://basarat.gitbooks.io/typescript/docs/types/index-signatures.html