Skip to content

Conversation

@LuLaValva
Copy link
Member

@LuLaValva LuLaValva commented Oct 22, 2025

CodeRabbit has many noisy comments related to code snapshots. Since this is a large part of our manual review process, it is okay for AI to ignore them.

Summary by CodeRabbit

  • Chores
    • Updated code review configuration settings to optimize file filtering and review processes.

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

⚠️ No Changeset found

Latest commit: 36faa8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Oct 22, 2025

Walkthrough

A new path_filters configuration is added to .coderabbit.yml with two entries: one to exclude snapshot directories and another to target source files within the src directory. This narrows the scope of files processed by the configuration.

Changes

Cohort / File(s) Summary
Configuration Update
​.coderabbit.yml
Added path_filters configuration with exclusion pattern for __snapshots__ directories and inclusion pattern for src directories

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Through snapshots we hop, but skip their snare,
In src directories, our paths are fair.
With filters now set, we filter and bound,
Configuration hops—no better path found! 🌟

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly captures the main change by indicating that CodeRabbit’s configuration is being updated to ignore snapshot directories and other non-code files, directly reflecting the added path filters and aligning with the PR’s stated objective of reducing noise from snapshot comments.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch coderabbit-ignore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (4aa8120) to head (36faa8a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2903   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         372      372           
  Lines       46179    46179           
  Branches     3741     3741           
=======================================
  Hits        40884    40884           
  Misses       5261     5261           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 85df4a7 and 36faa8a.

📒 Files selected for processing (1)
  • .coderabbit.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: test: node@22
  • GitHub Check: test: node@18
  • GitHub Check: test: node@20
  • GitHub Check: Analyze (javascript)

Comment on lines +2 to +3
- "!**/__snapshots__/**"
- "**/src/**"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

Reorder filters so snapshots actually stay out.

With Git/CodeRabbit sparse checkout semantics the last matching glob decides inclusion. Because the include "**/src/**" comes after the exclude, any path like packages/foo/src/__snapshots__/bar.snap matches the include last and slips back in. Move the include ahead of the exclude (or add a more specific trailing !**/src/**/__snapshots__/**) so snapshots remain filtered.

Apply this diff to fix the ordering:

 path_filters:
-  - "!**/__snapshots__/**"
-  - "**/src/**"
+  - "**/src/**"
+  - "!**/__snapshots__/**"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- "!**/__snapshots__/**"
- "**/src/**"
path_filters:
- "**/src/**"
- "!**/__snapshots__/**"
🤖 Prompt for AI Agents
In .coderabbit.yml around lines 2 to 3, the include/exclude ordering lets src
snapshots slip back in; move the include "**/src/**" above the exclude
"!**/__snapshots__/**" so the exclude is applied last, or alternatively add a
more specific trailing exclusion "!**/src/**/__snapshots__/**" (or both) so
paths like packages/foo/src/__snapshots__/bar.snap remain filtered out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants