Version: 0.2.0 - Multiple Models #6
Conversation
…solver, and vector modules. test: Update tests to reflect recent changes.
…features build: Migrate from Parcel to Vite feat: Enable simultaneous compilation and solving of multiple models.
There was a problem hiding this comment.
thanks @acosta-leandro, this looks great. A few minor points below
|
|
||
| // @ts-expect-error | ||
| let stderr = new SimpleOpenFile(wasi.fds[2].file); | ||
| const defaultBaseUrl = "https://compbio.fhs.um.edu.mo/diffeq"; |
There was a problem hiding this comment.
not sure if you meant to do this, but I'm happy if you want to run the default server :)
| static get(id?: string) { | ||
| if (id) { | ||
| return this.models.get(id); | ||
| } |
There was a problem hiding this comment.
if an id is supplied but not in the registry, you might want to throw an error here. I can imagine that it would be easy to just have a typo in your id name and you would want to know about that rather than just get the default model
| // Solve code1 (default model) | ||
| let options1 = new Options({}, 'model1'); | ||
| let solver1 = new Solver(options1, 'model1'); | ||
| let times1 = new Vector([0, 2], getModel('model1').vectorFunctions); |
There was a problem hiding this comment.
I find this api a bit inconsistent. To construct a solver you pass in the id, for example "model1", but to construct a vector you pass in the vectorFunctions? Why not make it the same as the solver api, that is just pass in the id "model1" to the constructor?
No description provided.