Skip to content

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Sep 3, 2025

This PR changes the aria-level attribute from the semantic enrichment to data-semantic-level-number to avoid ARIA errors with level number 0, since this really isn't being used as an actual aria level anyway.

@dpvc dpvc requested a review from zorkow September 3, 2025 13:54
@dpvc dpvc added this to the v4.0.1 milestone Sep 3, 2025
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.72%. Comparing base (afaf1ea) to head (4b8c0cb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1344   +/-   ##
========================================
  Coverage    86.72%   86.72%           
========================================
  Files          337      337           
  Lines        84145    84145           
  Branches      3140     3140           
========================================
  Hits         72971    72971           
  Misses       11174    11174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant