Skip to content

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Sep 7, 2025

This PR adds more sanitization for style attributes. It turns out that style parsing is kind of wonky, and it seems that a newline in the style attribute will end a style specification even if it is inside a quotation mark. So this PR turns newlines into spaces in styles to avoid that, and alters the split parameters for \mmlToken to be more in line with the parsing of styles. It also removes some unnecessary as OptionList casting.

@dpvc dpvc requested a review from zorkow September 7, 2025 16:47
@dpvc dpvc added this to the v4.0.1 milestone Sep 7, 2025
Copy link

codecov bot commented Sep 7, 2025

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.71%. Comparing base (afaf1ea) to head (e9d899a).

Files with missing lines Patch % Lines
ts/adaptors/HTMLAdaptor.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1348      +/-   ##
===========================================
- Coverage    86.72%   86.71%   -0.01%     
===========================================
  Files          337      337              
  Lines        84145    84148       +3     
  Branches      3140     4769    +1629     
===========================================
  Hits         72971    72971              
+ Misses       11174    11154      -20     
- Partials         0       23      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant