Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Nov 16, 2025

Node v25 makes the --localstorage-file a requirement for apps that use localStorage, so I've added it here.

@dpvc dpvc requested a review from zorkow November 16, 2025 20:45
@dpvc dpvc added this to the v4.1.0 milestone Nov 16, 2025
@dpvc
Copy link
Member Author

dpvc commented Nov 16, 2025

Well, it looks like our workflow doesn't allow this flag. I'm not sure what node version is being used, but I guess it is note v25. So we can ignore this PR for now, but may need to make it in the future.

@dpvc dpvc removed this from the v4.1.0 milestone Nov 16, 2025
@dpvc dpvc marked this pull request as draft November 16, 2025 21:02
@zorkow
Copy link
Member

zorkow commented Nov 19, 2025

Well, it looks like our workflow doesn't allow this flag. I'm not sure what node version is being used, but I guess it is note v25. So we can ignore this PR for now, but may need to make it in the future.

According to blog post node24 should replace node20 as default as of this autumn. Start of winter is Dec 21, so there is still a bit of time...
Anyway, in the meantime we can force the use of node24 explicitly.

I will push a fix to this branch.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.77%. Comparing base (e8bfee1) to head (447f90a).
⚠️ Report is 26 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #1389     +/-   ##
==========================================
  Coverage    86.77%   86.77%             
==========================================
  Files          338      338             
  Lines        84548    84548             
  Branches      3173     4812   +1639     
==========================================
  Hits         73367    73367             
+ Misses       11181    11158     -23     
- Partials         0       23     +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zorkow zorkow marked this pull request as ready for review November 19, 2025 16:28
@dpvc
Copy link
Member Author

dpvc commented Nov 19, 2025

Thanks for taking care of this.

@zorkow
Copy link
Member

zorkow commented Nov 19, 2025

@dpvc tests are running now. I think this PR can be merged.

  • test.yml now uses explicitly node24. We could remove this again in the near future or keep to have finer control over our test environment.
  • In addition, I renamed the jobs in test.yml and publish.yml to something more meaningful than setup and also to be able to distinguish them to be able to select them when running locally with act.

@dpvc dpvc merged commit 685a53b into develop Nov 20, 2025
3 checks passed
@dpvc dpvc deleted the fix/node-25 branch November 20, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants