-
-
Notifications
You must be signed in to change notification settings - Fork 120
Clarify vendor prefixing requirements #2222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Johannes Marbach <[email protected]>
b39dbcf
to
7f59715
Compare
content/proposals.md
Outdated
|
||
```json | ||
{ | ||
"errcode": "ORG.MATRIX.MSCXXXX.M_INVALID_EMAIL", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://spec.matrix.org/v1.16/client-server-api/#standard-error-response suggests that ORG.MATRIX.MSCXXXX_INVALID_EMAIL
would be the correct prefix.
The Foundation's preferred prefix is documented primarily for ourselves - it's not intended to be used in examples. It's also not recommended for folks outside the Foundation to use the Foundation's prefix. |
Oh! I guess everybody is doing it wrong all the time then. 😯 If this is only for Foundation staff / SCT members, should it even be mentioned in the docs here? And what prefix should people without ownership of a domain use? |
in the Java world, people typically use The Foundation's (not just SCT's) namespace should remain in the spec, but clarified that it's an example of how one might want to structure their own namespace. |
So Foundation staff and SCT get to use |
Anyone operating under the Foundation should be using |
Signed-off-by: Johannes Marbach <[email protected]>
Have changed the text accordingly. We might want to make some noise about this as I don't believe many people follow it in practice and I have never seen it flagged in proposal review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nitpicks.
Co-authored-by: Alexey Rusakov <[email protected]>
Co-authored-by: Alexey Rusakov <[email protected]>
Following the discussion in matrix-org/matrix-spec-proposals#4335 (comment), this is an attempt to clarify the requirements for vendor prefixing. This PR includes the following changes:
The nested bullets were already quite long before making it hard to follow the outer list.
org.matrix
being "recommended" doesn't apply to the general public.These stem from my own observations of how people used prefixes in the past.
The
proposals
section doesn't seem to have its own changelog category, so I pickedinternal
.Aaaand looks like I scored the #2222 pull request! 🎉😅
Pull Request Checklist
Preview: https://pr2222--matrix-spec-previews.netlify.app