Skip to content

Conversation

@adamvy
Copy link

@adamvy adamvy commented Jun 16, 2025

No description provided.

@adamvy adamvy requested a review from tulir June 16, 2025 16:51
@tulir
Copy link
Member

tulir commented Jun 16, 2025

Unknown errors intentionally exclude the error as it can be absolutely anything. Some other bridges put it in info -> go_error in case it's needed for metrics/logs/etc, but message is meant for things that are shown to users directly

@tulir
Copy link
Member

tulir commented Jun 16, 2025

(the error is already logged above the if)

@adamvy
Copy link
Author

adamvy commented Jun 16, 2025

I guess, UNKNOWN_ERRORs should be minimized anyways, I kind of would prefer an unhelpful error message over nothing but i've put it in go_error fo rnow

@tulir tulir changed the title CLI-216: pass up error message for unknown error client: pass up error message for unknown error Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants