Added checks for the mavlink definitions

[reedev]

Resolves #2665

[JonasVautherin]

Thanks!

When are those defined? By the superbuild? Just to understand 😊. I guess I'm wondering if those should not be exposed as CMake options?

[reedev]

Hi,

I am not sure what it means 'by the superbuild' but the url to the 4 xml files are set in src/mavsdk/core/CMakeLists.txt and now I added a check to set them only when they are not already set (via cmake). Of course, it could be nicer to use a single path to the files. We can easily change that.

[JonasVautherin]

Right, sorry it was late an I wasn't clear 😅.

I was wondering if we should not take this as an opportunity to add them as options, next to MAVLINK_DIALECT here: https://github.com/mavlink/MAVSDK/blob/main/CMakeLists.txt#L7. So that it makes it clear that they can be set manually

[reedev]

Sure, good suggestion to keep things consistent. I will try it out and make another PR (not right now, at a later moment).

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud