Skip to content

Conversation

@HTRamsey
Copy link
Collaborator

@HTRamsey HTRamsey commented Jul 3, 2025

Closes #12612

Courtesy of @jnomikos & Ascend Engineering

@HTRamsey HTRamsey force-pushed the dev-terrain-warning branch from 1a190a4 to ce5be93 Compare July 3, 2025 07:34
@jnomikos
Copy link
Contributor

2.038 - critical: Fact name "altitudeWarnMaxAGL" not found in ":/json/App.SettingsGroup.json" (default:SettingsGroup::_createSettingsFact:30)

Did you forget to commit the App.SettingsGroup.json code?

@HTRamsey HTRamsey force-pushed the dev-terrain-warning branch from ce5be93 to 48f0411 Compare July 20, 2025 09:41
@HTRamsey HTRamsey force-pushed the dev-terrain-warning branch from 48f0411 to ae079ed Compare July 20, 2025 23:24
@HTRamsey HTRamsey requested a review from jnomikos July 20, 2025 23:25
@HTRamsey
Copy link
Collaborator Author

2.038 - critical: Fact name "altitudeWarnMaxAGL" not found in ":/json/App.SettingsGroup.json" (default:SettingsGroup::_createSettingsFact:30)

Did you forget to commit the App.SettingsGroup.json code?

I forgot like half the PR somehow

@HTRamsey HTRamsey marked this pull request as ready for review August 2, 2025 04:55
@github-actions github-actions bot added the stale label Sep 2, 2025
@HTRamsey HTRamsey requested review from DonLakeFlyer and removed request for jnomikos September 16, 2025 05:06
@DonLakeFlyer
Copy link
Contributor

I looked but there isn't much here. Assume it's still missing stuff.

@github-actions github-actions bot removed the stale label Sep 28, 2025
@HTRamsey HTRamsey marked this pull request as draft October 10, 2025 06:19
@HTRamsey
Copy link
Collaborator Author

Think it should be all there. It's just a warning above/below set altitudes so shouldn't be much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Safety, define altitude threshold and warn user if drone crosses threshold. Base it on terrain data if provided.

3 participants