Skip to content

Conversation

HTRamsey
Copy link
Collaborator

Latest MacOS needs 6.9+

@HTRamsey HTRamsey requested a review from Copilot September 24, 2025 11:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates Qt version from 6.8.3 to 6.10.0 across the project to meet macOS compatibility requirements.

  • Update Qt version references throughout build scripts, configuration files, and documentation
  • Update Android build configuration including permissions and manifest settings
  • Update CI/CD workflow configurations to use Qt 6.10.0

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
translations/qgc-lupdate.sh Updated Qt path pattern to support version 6.10.0
tools/setup/install-qt-*.sh/.ps1 Updated default Qt version to 6.10.0 for all platforms
docs/en/qgc-user-guide/releases/daily_build_new_features.md Updated documentation to reflect Qt 6.10.0 usage
docs/en/qgc-dev-guide/getting_started/index.md Updated build example to use templated Qt version
deploy/vagrant/* Updated Vagrant configuration for Qt 6.10.0 paths
deploy/linux/appimagecraft.yml Updated Qt root path for Linux AppImage builds
deploy/docker/Dockerfile-build-ubuntu Updated Qt environment path
cmake/platform/Android.cmake Updated Qt version check and Android permissions configuration
cmake/CustomOptions.cmake Updated Qt version constraints and Android SDK version
android/* Updated Android build configuration and manifest
.github/workflows/* Updated all CI workflows to use Qt 6.10.0
.github/actions/qt-android/action.yml Updated default Qt version for Android action

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

android:allowBackup="true"
android:fullBackupOnly="false"
android:icon="@drawable/icon"
android:icon="-- %%INSERT_APP_ICON%% --"
Copy link
Preview

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app icon placeholder format appears incorrect. Qt's Android deployment typically expects @drawable/icon format, not -- %%INSERT_APP_ICON%% --.

Suggested change
android:icon="-- %%INSERT_APP_ICON%% --"
android:icon="@drawable/icon"

Copilot uses AI. Check for mistakes.

@DonLakeFlyer
Copy link
Contributor

Thanks so much for getting rolling on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants