ui/virtualconsole: fix sorting in the level tab of the slider dialog #1763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1722 (or 4bbba7b, respectively) introduced the possibility to sort the fixture-channel-list on the
Levelpage of Virtual Console Slider properties dialog.However, this was done by comparing the channel names as a string and thus introduced known "sorting anomalies": Channel 1 - Channel 10 - Channel 11 - Channel 2 - ... (tested with the
Lixada Mini Gobo Moving Headfixture).In my opinion, this is particularly unintuitive for non-programmer users of QLC+.
This PR attempts to fix this problem by basing the sort on the numeric channel id instead of the string name.
(I am not very familiar with Qt Framework and its internals, so if there is a better solution, please treat this PR as an issue report and ignore my code.)