Fixtureeditor/mode editor: disable "source" channel item in ActsOn co… #1768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mbobox list
Apparently the docs on Fixture editor's ActsOn setting are not being read/found or misunderstood constantly by new contributors of fixture definitions. One reason might be that the Mode editor screenshot in the manual is from an older version and doesn't even include the "Acts On:"column so the text explaining the functionality can easily be overseen or just be ignored, IMHO.
So this PR tries to reduce this common error for new users by disabling the channel the combobox is clicked on.
This is just a simple workaround, but at least it might help avoiding the same mistake again and again.
A more complete solution would be to preselect and enable only possible target channels for a certain channel type, but that's beyond my programming capabilities I fear...