Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/video/video.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ export default (
BaseComponent,
mapStateToProps = defaultMapStateToProps,
mapVideoElToProps = defaultMapVideoElToProps,
mergeProps = defaultMergeProps
mergeProps = defaultMergeProps,
videoId
) => class Video extends Component {
constructor(props) {
super(props);
Expand Down Expand Up @@ -102,7 +103,10 @@ export default (
}

componentDidMount() {
this.videoEl = this.el.getElementsByTagName('video')[0];
const videoEls = this.el.getElementsByTagName('video');
this.videoEl = videoId
? videoEls.namedItem(videoId)
: videoEls[0];
this.bindEventsToUpdateState();
}

Expand Down
25 changes: 22 additions & 3 deletions src/video/video.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ const TestVideo = ({ video, ...restProps }) => {
<video {...restProps}>
<source src="1" />
</video>
<video
id="video2"
{...restProps}
>
<source src="2" />
</video>
<TestControl {...video} />
</div>
);
Expand Down Expand Up @@ -228,7 +234,20 @@ describe('video', () => {
expect(component.find(TestVideo).prop('duplicateKey')).toBe('mapVideoElToProps');
});
});
});



describe('when passing in a video id as the fourth argument to the HOC', () => {
const videoEl = { id: 'video2' };
beforeEach(() => {
component = shallow(
<Component />
);

// Emulate videoEl being present
// e.g. componentDidMount
component.instance().videoEl = videoEl;
});
it('should find the video by id', () => {
expect(videoEl.id).toEqual('video2');
});
});
});