Ff145 RTCEncodedAudioFrame/RTCEncodeVideoFrame constructor/metadata #28242
+1,312
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:api
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Open
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF145 makes
RTCEncodedAudioFrameandRTCEncodeVideoFrameget constructors in https://bugzilla.mozilla.org/show_bug.cgi?id=1975032These include an
options.metadataproperty that contains the same kind of object as returned bygetMetadata().This adds the subfeatures for both cases which duplicate each other.
The results are based on test https://jsfiddle.net/jib1/5t1mehn4/ from https://bugzilla.mozilla.org/show_bug.cgi?id=1975032#c7 along with version support for the whole thing went into Safari (26 - https://webkit.org/blog/17333/webkit-features-in-safari-26-0/).
The test worked for Chrome, but not in browserstack. Therefore I have assumed that except for audioLevel the properties were added in first release of the constructor.
Note that the last commit adds sequenceNumber and recieveTime. I cannot see these in the test above, but was able to observed them in WPT tests by debugging. 68f2acd
Related docs work can be tracked in mdn/content#41508