Skip to content

Bug 1886894 Clear sessionStorage in browsingData remove options #41609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bug 1886894 Clear sessionStorage in browsingData remove options #41609

wants to merge 4 commits into from

Conversation

@rebloor
Copy link
Contributor

@rebloor rebloor commented Oct 20, 2025 •
edited
Loading

Description

This PR addresses the dev-docs needed requirements of Bug 1886894 Clear sessionStorage in browsingData.remove() for parity with "Clear Cookies and Site Data". It includes:

  • a release note
  • update to the browsingData.removeLocalStorage, browsingData.remove, and browsingData.DataTypeSet documentation.

Related issues and pull requests

Related BCD changes in PR mdn/browser-compat-data#28261.

@rebloor rebloor requested review from Rob--W and dotproto October 20, 2025 17:43
@rebloor rebloor self-assigned this Oct 20, 2025
@rebloor rebloor requested review from a team as code owners October 20, 2025 17:43
@rebloor rebloor requested review from pepelsbey and removed request for a team October 20, 2025 17:43
@rebloor rebloor added the Content:WebExt WebExtensions docs label Oct 20, 2025
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed labels Oct 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025 •
edited
Loading

Preview URLs (12 pages)
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/146
Title: Firefox 146 release notes for developers (Nightly)

(comment last updated: 2025-10-21 01:29:41)

Rob--W
Rob--W requested changes Oct 20, 2025
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on specific lines; please double check if there are any inconsistencies in other places in the browsingData API docs that need to be updated.

I haven't checked whether all (un)supported options are correctly listed; I'll do that at the next review pass.

files/en-us/mozilla/add-ons/webextensions/api/browsingdata/datatypeset/index.md Outdated
- : `boolean`. IndexedDB data.
- `localStorage` {{optional_inline}}
- : `boolean`. Local storage data.
- : `boolean`. Local and session storage data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid confusion with the storage.local and storage.session extension APIs, could you reference localStorage and sessionStorage API docs (with this spelling)? E.g. local storage (localStorage) and session storage (sessionStorage), with the API names between braces pointing to the API docs.

The generic term is web storage (but most people know it by local storage, I guess?). API docs that encompasses both storage APIs: https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API

files/en-us/mozilla/add-ons/webextensions/api/browsingdata/removaloptions/index.md Outdated
Values of this type are objects. They contain these properties:

- `cookieStoreId` {{optional_inline}}
- : `string`. This property only applies to cookies and indexedDB items. The removal is limited to items belonging to a specific [cookie store](/en-US/docs/Mozilla/Add-ons/WebExtensions/API/cookies/CookieStore) as specified by the ID. See [Work with contextual identities](/en-US/docs/Mozilla/Add-ons/WebExtensions/Work_with_contextual_identities) for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enumeration should mention localStorage too.

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Oct 21, 2025
@rebloor rebloor requested a review from Rob--W October 21, 2025 01:29
@rebloor rebloor mentioned this pull request Oct 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotproto dotproto Awaiting requested review from dotproto

@pepelsbey pepelsbey Awaiting requested review from pepelsbey pepelsbey was automatically assigned from mdn/core-yari-content

@Rob--W Rob--W Awaiting requested review from Rob--W

Requested changes must be addressed to merge this pull request.

Assignees

@rebloor rebloor

Labels

Content:Firefox Content in the Mozilla/Firefox subtree Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rebloor @Rob--W