Skip to content

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented Sep 29, 2025

Purpose

Fixes OpenMDAO/OpenMDAO#3621, making OpenConcept compatible with latest version of OpenMDAO.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • - Bugfix (non-breaking change which fixes an issue)
  • - New feature (non-breaking change which adds functionality)
  • - Breaking change (non-backwards-compatible fix or feature)
  • - Code style update (formatting, renaming)
  • - Refactoring (no functional changes, no API changes)
  • - Documentation update
  • - Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner September 29, 2025 23:22
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.03%. Comparing base (82bdf26) to head (650385d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   82.04%   82.03%   -0.02%     
==========================================
  Files         103      103              
  Lines       10724    10724              
==========================================
- Hits         8799     8797       -2     
- Misses       1925     1927       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A-CGray
Copy link
Member Author

A-CGray commented Oct 2, 2025

Failing tests are being caused by pyCycle, I've opened this PR to fix the issue

@A-CGray
Copy link
Member Author

A-CGray commented Oct 15, 2025

@kanekosh OpenMDAO/pyCycle#109 is now merged, but we need to wait for a new pyCycle release to be made before our tests will pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subsystems added during _setup_procs are ignored

1 participant