Skip to content

Conversation

@A-CGray
Copy link
Member

@A-CGray A-CGray commented Apr 8, 2025

Purpose

Bret Naylor from the OpenMDAO team implemented this performance improvement while helping us debug some MPhys performance issues. Essentially, it changes the calculation of the total jacobian from a series of mat-vec products in a python for loop to a single mat-mat product, which should be faster when there are a lot of outputs (e.g many thickness constraints).

Expected time until merged

No rush, we should take our time to make sure this won't break anything

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner April 8, 2025 20:45
@A-CGray A-CGray requested review from anilyil and sabakhshi April 8, 2025 20:45
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.10%. Comparing base (ee331a6) to head (23375b8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   67.10%   67.10%   -0.01%     
==========================================
  Files          48       48              
  Lines       12378    12377       -1     
==========================================
- Hits         8306     8305       -1     
  Misses       4072     4072              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A-CGray A-CGray requested a review from ArshSaja September 22, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants