Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
1: Addresses #273
2: Improvements to
nom_addPointSet
reshape
so that it works whether supplied points are flattened or (N,3) array3: Add helpful error message if
nom_getDVGeo
is called beforesetup
The DVGeo instances associated with an instance of
OM_DVGEOCOMP
are only created whensetup
is called. Because OpenMDAO callssetup
starting from top level groups and works down, callingnom_getDVGeo
(or another method that calls it such asnom_addPointSet
) in thesetup
method of an OpenMDAO group that contains anOM_DVGEOCOMP
will cause an error. However, the error message that currently gets raised when you do this doesn't make this obvious:This PR adds a helpful error that is raised in these cases that recommends users move their function call to the
configure
method, wherenom_getDVGeo
will work:Expected time until merged
Soon
Type of change
Testing
Checklist
ruff check
andruff format
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable