Skip to content

Add DateTime.getNormalizedDay #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add DateTime.getNormalizedDay #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/datetime-class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
import { MILLISECONDS_PER_WEEK } from './utils/const.js'
import { datetime, weekNumber } from './index.js'
import { getNormalizeDay } from './utils/date.js'

export class DateTime extends Date {

/**
* Get the day index of the week, except Sunday is 7 instead of 0.
*
* @returns {number}
*/
getNormalisedDay = () => getNormalizeDay(this)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be getNormalizedDay with a z instead of a s.


/**
* Returns the week of the year (`1`–`53`) of the specified date according to
* local time, as defined by the WHATWG and the ISO-8601 specs:
Expand Down
2 changes: 2 additions & 0 deletions src/datetime-class.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ describe('DateTime class', () => {
})
})

describe.todo('.getNormalisedDay()', () => {})

describe('.getWeek()', () => {

test('returns the week number', () => {
Expand Down