Fix loader batching logic in defineLoader + upgrade dependencies and GraphiQL #1143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix internal
defineLoader
batching issue + dependency & GraphiQL updatesThis pull request fixes a problem in Mercurius' internal
defineLoader
function, where GraphQL field loaders were being called once per item, instead of once per field with batching.✅ What was fixed
The problem was caused by using complex objects (
{ obj, params }
) as loader keys, which prevented Mercurius from recognizing repeated calls as "the same".We now use a
serialize()
function that:obj.id
andparams.lang
to create a fast and consistent batching keyJSON.stringify({ obj, params })
ifid
is not available✅ Also included
main.js
,config.js
) to the latest version🧪 Real-world test results (
k6
)Before (no batching):
After (with batching):
🔒 Notes