Fix: Update button colors on Models pages #2393
Conversation
rs on models pages - changed primary action buttons (.import) to saffron yellow (#ebc017) - changed secondary action buttons (.import-secondary) to keppel green (#00b39f) - added tertiary button class (.import-tertiary) with transparent background - updated 'add new model' button to use secondary styling - updated 'quick start' button in modal to use secondary styling closes meshery#2389 Signed-off-by: phoenixcodeforces-blip <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @phoenixcodeforces-blip, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses issue #2389 by implementing a comprehensive update to the button styling across the Models pages. The changes ensure that primary and secondary action buttons adhere to specified color palettes, and a new tertiary button style is introduced for additional design flexibility. Specific buttons, such as 'Add New Model' and 'Quick Start', have been re-categorized to align with the new secondary styling, enhancing visual consistency and user experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the button colors on the Models pages to match the design requirements, addressing issue #2389. The primary action buttons are changed to saffron yellow, secondary buttons to keppel green, and a tertiary button class is added with a transparent background. The 'Add New Model' and 'Quick Start' buttons are updated to use secondary styling. The changes involve modifications to _sass/catalog.scss, _layouts/single-page-model.html, and _includes/models/modal.html. I have identified a potential issue with the color definition for the .import-secondary class in _sass/catalog.scss.
|
Thank you for your contribution! |
|
Hi @Rajesh-Nagarajan-11 |
2 participants
Description
This PR fixes #2389 by updating the button colors on the Models pages to match the design requirements.
Changes Made
.import) to saffron yellow (#EBC017).import-secondary) to keppel green (#00B39F).import-tertiary) with transparent background and 1px solid borderFiles Modified
_sass/catalog.scss- Updated button color classes_layouts/single-page-model.html- Changed "Add New Model" button class_includes/models/modal.html- Changed "Quick Start" button classTesting
Screenshots
Notes for Reviewers
Please verify the color values match the design specifications in #2389.
[Signed commits](https://docs.meshery.io/project/contributing#signing-off-on-commits-developer-certificate-of-origin)