feat: add fixed position coordinate picker with map interface #909

dzienisz · 2025-10-26T11:25:41Z

Description

Remove Fixed Position Picker & Simplify Position Config

Summary

Replaced the old FixedPositionPicker UI (map, tooltips, per-component admin messages) with a simpler, form-based workflow directly inside Position.tsx. The form now owns latitude, longitude, and altitude fields, validating and saving coordinates through the existing config submission flow while still sending the setFixedPosition admin message when needed. Unused translations and the obsolete component were removed.

Related Issues

Fixes: Users couldn’t reliably save fixed position coordinates after the picker button removal.

Changes Made

Removed

FixedPositionPicker.tsx – entire component deleted (map picker, tooltips, buttons, admin-message wiring).
config.json – removed translations for picker map hints, buttons, error/success toasts.

Updated Files

Position.tsx
- Added latitude/longitude/altitude fields to the form schema and UI (with suffixes and clearer descriptions).
- Integrated validation + default altitude (0) directly into form state.
- On submit, sends setFixedPosition admin message when fixed-position coordinates are present; coordinates are omitted from config payload.
- Uses form disabledBy to hide coordinate fields unless “Fixed Position” is enabled.
validation/config/position.ts
- PositionValidationSchema now includes optional latitude, longitude, altitude.
config.json (en)
- Cleaned up unused fixed-position translations; kept only label/description entries still referenced in UI.

Key Points

Coordinates are fully form-managed; no duplicate state between picker + form.
Precision clarified: UI descriptions mention 7 decimal max.
Suffixes display full units (“Degrees”, “Meters”/“Feet”) for clarity.
Altitude defaults to 0 when no existing value is present.
No lingering references to the removed picker (imports deleted, file removed).
Translation file only contains active keys.

Testing

✅ Lint: pnpm run lint (root) — passes.
✅ Manual checks:
- Toggling Fixed Position on/off shows/hides coordinate fields.
- Entering lat/lon/alt values saves via form submit; sends admin message when fixed position is enabled.
- Disabled state respected when fixed position is off.
- Metric vs. imperial display units update suffix and description text.
- No references to removed picker remain.

Checklist

Code follows project style/patterns.
Type safety maintained (PositionValidationSchema updated).
Translations cleaned.
Linting passes.
Removed obsolete component and assets.

vercel · 2025-10-26T11:25:46Z

@dzienisz is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

danditomaso

Overall really glad to see this has been added to the code base, it has been needed for a while.

I will need to see some changes reverted otherwise it will cause all kinds of type issues around the code base. Additionally, the Fixed Position component must be added to the DynamicFormField and referenced using the type field by its string value (known as a factory function). Once you look at the DynamicFormField component you'll see the pattern. I'm available to help answer any questions on will be required to get this merged

packages/core/src/utils/transform/decodePacket.ts

packages/web/public/i18n/locales/en/config.json

packages/web/src/components/Form/DynamicForm.tsx

packages/web/src/components/Form/FormWrapper.tsx

packages/web/src/components/PageComponents/Settings/FixedPositionPicker.tsx

packages/web/src/components/PageComponents/Settings/Position.tsx

dzienisz · 2025-10-26T14:51:06Z

I am open to all suggestions. This is my first big PR. I can improve it next week.

danditomaso · 2025-11-10T01:39:17Z

@dzienisz Wanted to follow up and see if the fixes were going to be added to this PR?

dzienisz · 2025-11-10T08:25:11Z

@dzienisz Wanted to follow up and see if the fixes were going to be added to this PR?

today, sorry for delay

- Created new FixedPositionPicker component with clickable map for setting device coordinates - Added form field type for fixed position picker that appears when fixedPosition toggle is enabled - Implemented position request functionality to retrieve current device location

- Added dynamic altitude unit (Meters/Feet) that respects the user's imperial/metric display preference - Updated altitude field description to show the appropriate unit instead of hardcoded "Meters"

- Replace hardcoded IDs with useId() hook for proper accessibility - Use Number.isNaN() instead of isNaN() for more reliable type checking - Add radix parameter to parseInt() and remove unnecessary fragment wrapper

- Removed dedicated FixedPositionPicker form field type in favor of toggle's additionalContent prop - Moved FixedPositionPicker to render conditionally within toggle field instead of as separate dynamic field - Streamlined form field types by eliminating FixedPositionPickerFieldProps

packages/web/src/components/Form/FormToggle.tsx

danditomaso · 2025-11-12T14:02:24Z

Can you remove the large white border and the padding around this new component, and with the exception of one other comment about using standards such as {...rest} in the component it looks good to go.

danditomaso · 2025-11-12T14:07:01Z

Also, how does this feature interact with the GPS Mode dropdown above? Can both be used at the same time?

danditomaso · 2025-11-12T15:34:39Z

Also, since. you mentioned some "recommended notes"

GPS Mode recommendation: Set to "DISABLED" or "NOT_PRESENT" when using fixed position for best results

This can be enforced at the field level, look for disabledBy: in the codebase, as its important users dont need a manual to use a new feature and that it "just works"

vercel · 2025-11-13T17:37:47Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
web-test	Ready	Preview	Comment	Nov 13, 2025 5:38pm

danditomaso · 2025-11-13T19:34:26Z

So I played with it a bit, and if I enter a lat or long greater than -90 - 90 it throws an error, or if you enter 3 digits at all, and click "set fixed position" the thrown error is caught by the top level error handler. This should really validate the input and display an error if the input isn't valid instead of throwing an error.

…s for fixed position - Removed FixedPositionPicker component with map interface - Added latitude, longitude, and altitude fields directly to position form - Moved coordinate validation into PositionValidationSchema with proper min/max bounds - Updated translation strings to include coordinate ranges and improved altitude description - Coordinates now sent via setFixedPosition admin message on form submit when fixedPosition is enabled

…d unused field spreading - Removed additionalContent prop and its JSDoc documentation from ToggleFieldProps - Removed rendering of additionalContent below toggle switch - Cleaned up Controller render function by removing unused rest spread operator - Renamed field destructuring to controllerField for clarity

dzienisz · 2025-11-14T14:21:42Z

@danditomaso Setting position does not work, and I'm not sure why.

danditomaso requested changes Oct 26, 2025

View reviewed changes

dzienisz force-pushed the feat/fixed-position branch 2 times, most recently from d3777e6 to 9b80d5e Compare October 29, 2025 13:48

dzienisz force-pushed the feat/fixed-position branch from 9b80d5e to 72dff84 Compare November 12, 2025 11:16

dzienisz force-pushed the feat/fixed-position branch from 72dff84 to c62c2d3 Compare November 12, 2025 11:37

dzienisz added 2 commits November 12, 2025 12:42

feat: display altitude unit based on user's display settings

536ec46

- Added dynamic altitude unit (Meters/Feet) that respects the user's imperial/metric display preference - Updated altitude field description to show the appropriate unit instead of hardcoded "Meters"

refactor: replace any type with MapLayerMouseEvent in map click handler

9f94e75

dzienisz requested a review from danditomaso November 12, 2025 11:44

dzienisz added 3 commits November 12, 2025 12:47

refactor: improve accessibility and code quality in FixedPositionPicker

7416784

- Replace hardcoded IDs with useId() hook for proper accessibility - Use Number.isNaN() instead of isNaN() for more reliable type checking - Add radix parameter to parseInt() and remove unnecessary fragment wrapper

style: format code with consistent line breaks and import ordering

fd289c3

danditomaso reviewed Nov 12, 2025

View reviewed changes

packages/web/src/components/Form/FormToggle.tsx Outdated Show resolved Hide resolved

dzienisz added 3 commits November 13, 2025 14:32

refactor: simplify fixed position picker container styling

c8f9584

feat: disable fixed position toggle when GPS is enabled

5011549

refactor: use ComponentRef instead of ElementRef in Switch component

ffa7042

dzienisz requested a review from danditomaso November 13, 2025 15:04

vercel bot deployed to Preview – web-test November 13, 2025 17:38 View deployment

dzienisz force-pushed the feat/fixed-position branch 2 times, most recently from 8c102c8 to b777c7b Compare November 14, 2025 13:56

dzienisz force-pushed the feat/fixed-position branch from b777c7b to 57612fa Compare November 14, 2025 13:59

dzienisz force-pushed the feat/fixed-position branch from 57612fa to 0d252aa Compare November 14, 2025 13:59

This was referenced Nov 16, 2025

Missing Fields for (lng & lat) at Fixed Location #87

Open

[Bug]: Web interface: No place to set fixed lat/long. #372

Closed

feat: add fixed position coordinate picker with map interface #909

Are you sure you want to change the base?

feat: add fixed position coordinate picker with map interface #909

Uh oh!

Conversation

dzienisz commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Remove Fixed Position Picker & Simplify Position Config

Summary

Related Issues

Changes Made

Removed

Updated Files

Key Points

Testing

Checklist

Uh oh!

vercel bot commented Oct 26, 2025

Uh oh!

danditomaso left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dzienisz commented Oct 26, 2025

Uh oh!

danditomaso commented Nov 10, 2025

Uh oh!

dzienisz commented Nov 10, 2025

Uh oh!

Uh oh!

danditomaso commented Nov 12, 2025

Uh oh!

danditomaso commented Nov 12, 2025

Uh oh!

danditomaso commented Nov 12, 2025

Uh oh!

vercel bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danditomaso commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dzienisz commented Nov 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dzienisz commented Oct 26, 2025 •

edited

Loading

danditomaso left a comment •

edited

Loading

vercel bot commented Nov 13, 2025 •

edited

Loading

danditomaso commented Nov 13, 2025 •

edited

Loading