tools: add formatting for wrap files and releases.json
#2374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have sanity_checks.py check that wrap files for modified subprojects are properly formatted, and have format.py reformat them. Do the formatting ourselves because ConfigParser doesn't preserve comments on write.
Have sanity_checks.py check that releases.json is formatted, and have format.py format it. Remove the sorted keys check since the format check subsumes it. We could also format ci_config.json, but sorting keys alphabetically would break some semantically meaningful groupings, so skip for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have sanity_checks.py check that
releases.jsonand wrap files for modified wraps are formatted, and haveformat.pyformat them. We could also formatci_config.json, but sorting keys alphabetically would break some semantically meaningful groupings, so skip for now.