Skip to content

PHP 8.4 compatibility #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2024
Merged

PHP 8.4 compatibility #222

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea8512b
Add PHP 8.3 and PHP 8.4 to matrix
ruudk Oct 31, 2024
3a353d8
Make compatible with PHP 8.4
ruudk Oct 31, 2024
fc29729
Merge branch 'messagebird:master' into patch-1
ruudk Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [ '7.4', '8.0', '8.1', '8.2' ]
php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
stability: [ prefer-stable ]

name: PHP ${{ matrix.php }} - ${{ matrix.stability }}
Expand Down
2 changes: 1 addition & 1 deletion src/MessageBird/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ class Client
*/
protected $numbersAPIClient;

public function __construct(?string $accessKey = null, Common\HttpClient $httpClient = null, array $config = [])
public function __construct(?string $accessKey = null, ?Common\HttpClient $httpClient = null, array $config = [])
{
if ($httpClient === null) {
$this->conversationsAPIHttpClient = new Common\HttpClient(
Expand Down
Loading