Convert all tests in torchbench to bf16 #118
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
msaroufim
reviewed
Aug 26, 2025
| @@ -245,7 +318,13 @@ def _validate_trace_file(trace_file: str, is_input: bool = True) -> str: | |||
| type=int, | |||
| help="Limit the number of operators to convert. (Useful for testing)", | |||
| ) | |||
| def main(log_level, mode, trace_file, parquet_name, upload_to_hf, limit): | |||
| @click.option( | |||
| "--force-dtype", | |||
There was a problem hiding this comment.
I'm suspicious about general dtype conversions, this seems like a massive footgun for correctness testing
There was a problem hiding this comment.
ohh if you have time let's chat about it offline, this was more so just executing on the rec from @malfet.
There was a problem hiding this comment.
Ok we chatted offline and this is specific to torchbench data prep
msaroufim
reviewed
Aug 26, 2025
| @@ -9,7 +9,25 @@ | |||
|
|
|||
| import tqdm | |||
| from BackendBench.utils import cleanup_memory_and_gpu, deserialize_args | |||
| from triton.testing import do_bench | |||
|
|
|||
| # Try to import triton, fallback to cpu_bench if not available | |||
There was a problem hiding this comment.
you don't have to make this work for cpu
There was a problem hiding this comment.
This is mostly to make testing easier when you don't have access to a gpu (I've gotten into the habit of developing on my laptop and using a devserver for testing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.