Skip to content

Conversation

PaliC
Copy link
Contributor

@PaliC PaliC commented Aug 29, 2025

The purpose of this PR is to rename several things for more accurate communication during our release. I made the following renames:

TorchBenchSuite → ModelTracesSuite
datasets → test_suites
huggingface_op_trace → backendbench_tests

Motivation for the renames

TorchBenchSuite → ModelTracesSuite

TorchBench is a misnomer here, as this test suite actually contains models from HuggingFace Transformers, TIMM, and TorchBench (which is actually the smallest contributor iirc). ModelTraces better captures that the test suite consists of model traces used in PyTorch CI. Given that we plan to expand this test suite primarily through additional traces, this name is more appropriate.

datasets → test_suites

This was poor naming on my part. When creating new test suites, I incorrectly called them datasets, which caused confusion.

huggingface_op_trace → backendbench_tests

I updated the repository name where ModelTracesSuite lives to correct the misnomer—it's a repository of test suites, not HuggingFace op traces.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 29, 2025
@PaliC PaliC requested review from msaroufim and jiannanWang August 29, 2025 05:50
@PaliC PaliC marked this pull request as ready for review August 29, 2025 05:57
@msaroufim
Copy link
Member

msaroufim commented Aug 29, 2025

I'm not a big fan of the new names or the old ones :P. Just so you don't get randomized updating the PR mind discussing these in an issue instead? Personally I'd prefer things that fully explain what something is like HF_TOP_MODEL_SHAPE. Tests is vague it could refer to things in test it could refer to suite? datasets could mean anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants