Added Performance tests

[ParamThakkar123]

Added performance tests instead of just correctness testing as given in issue #75 . Fix #75

[PaliC]

Thanks for the fix :) This will help us get our toy agent to also give us better performance as we iterate on it.

The only "please fix this" feedback is to rebase the pr and make sure it works on main (check comment about a recent refactor).

Otherwise, things generally look solid!

[ParamThakkar123]

@PaliC I made the changes suggested

[PaliC]

@ParamThakkar123 I think something went wrong with rebasing as there are callsites to functions which are no longer in the file.

I'd ensure that the tests added here work, and you should be good! Ensure that the tests that are added here work #158

Also you should be able to just use compile_kernel_from_string to grab the kernel function

[ParamThakkar123]

Sure @PaliC looking into it

[ParamThakkar123]

@PaliC I made some code changes and ensured that they work locally. Can you place take a look?

[PaliC]

There's a small comment you need to address, otherwise, it seems good to merge.

Thanks :)

[PaliC]

oops there's a bug

[ParamThakkar123]

@PaliC so should I go ahead and make the changes i described in that thread ?

[ParamThakkar123]

Sure @PaliC Made the fixes. And I left the refactor as it is if that wasn't something we need right now

[ParamThakkar123]

Can you please take a look ? If any changes are needed further I'll make them right away. Else we are ready to merge probably :). Sorry for the bugs I unknowingly introduced in the code @PaliC

[PaliC]

Thanks for dealing with the back and forth! It's good to merge :)

[ParamThakkar123]

Thanks @PaliC 🫡

[shaahins]

thanks for adding this @ParamThakkar123