-
Notifications
You must be signed in to change notification settings - Fork 11
Added Error Logging #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ParamThakkar123
wants to merge
12
commits into
meta-pytorch:main
Choose a base branch
from
ParamThakkar123:AgentErrors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added Error Logging #164
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
eac24fe
Added Error Logging
ParamThakkar123 25d090a
Updates
ParamThakkar123 31dbe75
rebase and agent_error fix
ParamThakkar123 01426d2
Updates
ParamThakkar123 f2aad73
Updates and Feedback noted
ParamThakkar123 102a8cd
Merge branch 'main' of https://github.com/meta-pytorch/BackendBench i…
ParamThakkar123 48400a5
Merge branch 'main' into AgentErrors
ParamThakkar123 e2f1c68
Rename done, ConnectionError Defined and reverted changes from kernel…
ParamThakkar123 796d015
Merge branch 'main' of https://github.com/meta-pytorch/BackendBench i…
ParamThakkar123 c172bf9
Updates
ParamThakkar123 17f4446
Updates
ParamThakkar123 a49c9fd
Merge branch 'main' of https://github.com/meta-pytorch/BackendBench i…
ParamThakkar123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Copyright (c) Meta Platforms, Inc. and affiliates. | ||
# All rights reserved. | ||
# | ||
# This source code is licensed under the BSD 3-Clause license found in the | ||
# LICENSE file in the root directory of this source tree. | ||
|
||
|
||
class AgentError(Exception): | ||
""" | ||
Exception raised for errors related to LLM/agent failures, | ||
such as rate limits, empty code, bad formatting, or API issues. | ||
""" | ||
|
||
def __init__(self, message: str): | ||
super().__init__(message) | ||
self.message = message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,9 +9,12 @@ | |
|
||
import anthropic | ||
import requests | ||
from requests.exceptions import ConnectionError | ||
from tenacity import retry | ||
from tenacity.wait import wait_random_exponential | ||
|
||
from BackendBench.errors import AgentError | ||
|
||
from .kernel_templates import KernelTemplateManager | ||
|
||
|
||
|
@@ -60,15 +63,26 @@ def readme_setup_section(self) -> str: | |
|
||
@retry(wait=wait_random_exponential(multiplier=2, min=1, max=60, exp_base=2)) | ||
def call_llm(self, prompt: str) -> str: | ||
response = self.client.messages.create( | ||
model=self.model, | ||
max_tokens=8000, | ||
temperature=0.2, | ||
timeout=120.0, | ||
messages=[{"role": "user", "content": prompt}], | ||
) | ||
content = response.content[0].text | ||
return content | ||
try: | ||
response = self.client.messages.create( | ||
model=self.model, | ||
max_tokens=8000, | ||
temperature=0.2, | ||
timeout=120.0, | ||
messages=[{"role": "user", "content": prompt}], | ||
) | ||
content = response.content[0].text | ||
if not content: | ||
raise ConnectionError( | ||
ParamThakkar123 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"API error: Empty response from LLM API (possible rate limit or outage)." | ||
) | ||
if "rate limit" in content.lower(): | ||
raise ConnectionError("API error: Rate limit encountered from LLM API.") | ||
return content | ||
except anthropic.AnthropicError as e: | ||
raise ConnectionError(f"API error: Anthropic API error: {e}") | ||
except Exception as e: | ||
raise ConnectionError(f"API error: Unexpected error: {e}") | ||
|
||
def generate_kernel( | ||
self, | ||
|
@@ -93,9 +107,7 @@ def generate_kernel( | |
|
||
try: | ||
content = self.call_llm(prompt) | ||
if not content: | ||
raise RuntimeError("Empty response from LLM relay server") | ||
|
||
# Only raise AgentError if kernel extraction fails | ||
extracted_code = self._extract_code_from_response(content) | ||
|
||
print("\n=== DEBUG: RAW LLM RELAY RESPONSE ===") | ||
|
@@ -106,25 +118,18 @@ def generate_kernel( | |
|
||
return extracted_code | ||
|
||
except requests.exceptions.RequestException as e: | ||
raise RuntimeError( | ||
f"Failed to communicate with LLM relay server for {op_name}: {str(e)}" | ||
) | ||
except AgentError: | ||
raise | ||
ParamThakkar123 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
except Exception as e: | ||
raise RuntimeError(f"Failed to generate kernel for {op_name}: {str(e)}") | ||
raise AgentError(f"Agent error: Failed to generate kernel for {op_name}: {str(e)}") | ||
ParamThakkar123 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
def _extract_code_from_response(self, response: str) -> str: | ||
if "```python" not in response: | ||
raise ValueError( | ||
"No Python code block found in LLM response. Response should contain ```python...``` block." | ||
) | ||
|
||
raise AgentError("Agent error: No Python code block found in LLM response.") | ||
start = response.find("```python") + len("```python") | ||
end = response.find("```", start) | ||
|
||
if end == -1: | ||
raise ValueError("Unclosed Python code block in LLM response.") | ||
|
||
raise AgentError("Agent error: Unclosed Python code block in LLM response.") | ||
return response[start:end].strip() | ||
|
||
|
||
|
@@ -180,17 +185,24 @@ def call_llm(self, prompt: str) -> str: | |
else None | ||
) | ||
|
||
response = requests.post( | ||
self.server_url, | ||
json=request_data, | ||
headers={"Content-Type": "application/json"}, | ||
timeout=120.0, | ||
proxies=proxies, | ||
) | ||
|
||
if response.status_code != 200: | ||
raise RuntimeError(f"Server returned status {response.status_code}: {response.text}") | ||
|
||
response_data = response.json() | ||
content = response_data.get("output", "") | ||
return content | ||
try: | ||
response = requests.post( | ||
self.server_url, | ||
json=request_data, | ||
headers={"Content-Type": "application/json"}, | ||
timeout=120.0, | ||
proxies=proxies, | ||
) | ||
if response.status_code != 200: | ||
raise AgentError( | ||
f"Agent error: Server returned status {response.status_code}: {response.text}" | ||
) | ||
response_data = response.json() | ||
content = response_data.get("output", "") | ||
if not content or "rate limit" in content.lower(): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As discussed before these should not be agent errors as these are issues with connecting to the server. |
||
raise AgentError("Agent error: Empty response or rate limit encountered.") | ||
return content | ||
except requests.exceptions.RequestException as e: | ||
raise AgentError(f"Agent error: Failed to communicate with LLM relay server: {str(e)}") | ||
ParamThakkar123 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
except Exception as e: | ||
raise AgentError(f"Agent error: Unexpected error in LLM relay call: {e}") | ||
ParamThakkar123 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.