Enable RDMA tests in OSS CI #1255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
force-pushed
the
export-D82699014
branch
from
94edb20 to
3a11da4
Compare
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 18, 2025
Summary: Pull Request resolved: meta-pytorch#1255 Ensure `cargo test -p monarch_rdma` runs on OSS CI Differential Revision: D82699014
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 18, 2025
Summary: Pull Request resolved: meta-pytorch#1255 Ensure `cargo test -p monarch_rdma` runs on OSS CI Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
3a11da4 to
bcc17b3
Compare
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 18, 2025
Summary: Pull Request resolved: meta-pytorch#1255 Ensure `cargo test -p monarch_rdma` runs on OSS CI Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
bcc17b3 to
b19c1cb
Compare
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 19, 2025
Summary: Ensure `cargo test -p monarch_rdma` runs on OSS CI Reviewed By: dulinriley Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
b19c1cb to
fff7d24
Compare
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
1 similar comment
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
force-pushed
the
export-D82699014
branch
from
fff7d24 to
c5bde33
Compare
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 19, 2025
Summary: Pull Request resolved: meta-pytorch#1255 Ensure `cargo test -p monarch_rdma` runs on OSS CI Reviewed By: dulinriley Differential Revision: D82699014
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 19, 2025
Summary: Pull Request resolved: meta-pytorch#1255 Ensure `cargo test -p monarch_rdma` runs on OSS CI Reviewed By: dulinriley Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
c5bde33 to
29dccc2
Compare
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 19, 2025
Summary: Pull Request resolved: meta-pytorch#1255 Ensure `cargo test -p monarch_rdma` runs on OSS CI Reviewed By: dulinriley Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
29dccc2 to
b202a72
Compare
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
force-pushed
the
export-D82699014
branch
from
b202a72 to
1b94aa2
Compare
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 19, 2025
Summary: Pull Request resolved: meta-pytorch#1255 Ensure `cargo test -p monarch_rdma` runs on OSS CI Reviewed By: dulinriley Differential Revision: D82699014
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 19, 2025
Summary: Pull Request resolved: meta-pytorch#1255 Ensure `cargo test -p monarch_rdma` runs on OSS CI Reviewed By: dulinriley Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
c74a3cc to
b77cdd0
Compare
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 21, 2025
Summary: Ensure `cargo test -p monarch_rdma` runs on OSS CI Reviewed By: dulinriley Differential Revision: D82699014
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 21, 2025
Summary: Ensure `cargo test -p monarch_rdma` runs on OSS CI Reviewed By: dulinriley Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
b77cdd0 to
12dd223
Compare
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
force-pushed
the
export-D82699014
branch
from
12dd223 to
f1b1282
Compare
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 22, 2025
Summary: Ensure `cargo test -p monarch_rdma` runs on OSS CI Reviewed By: dulinriley Differential Revision: D82699014
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 22, 2025
Summary:
- Ensure `cargo test -p monarch_rdma` runs on OSS CI
- Break out new testing infra into its own runner (see rationale below).
Given test suites getting relatively large and different paths (ie. cargo test vs pytest/pyright), which was actually helpful since some flakiness within python path having some long running examples. Trade off is slightly more resources; so can revisit later if issue.
{F1982168077}
Reviewed By: dulinriley
Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
f1b1282 to
4bbd4f5
Compare
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 22, 2025
Summary:
- Ensure `cargo test -p monarch_rdma` runs on OSS CI
- Break out new testing infra into its own runner (see rationale below).
- `cargo test` in general will work for repo, but we have a lot of broken tests to resolve.
Given test suites getting relatively large and different paths (ie. cargo test vs pytest/pyright), which was actually helpful since some flakiness within python path having some long running examples. Trade off is slightly more resources; so can revisit later if issue.
{F1982168077}
Reviewed By: dulinriley
Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
4bbd4f5 to
980f3bd
Compare
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
1 similar comment
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 22, 2025
Summary: Pull Request resolved: meta-pytorch#1255 - Ensure `cargo test -p monarch_rdma` runs on OSS CI - Break out new testing infra into its own runner (see rationale below). - `cargo test` in general will work for repo, but we have a lot of broken tests to resolve. Given test suites getting relatively large and different paths (ie. cargo test vs pytest/pyright), which was actually helpful since some flakiness within python path having some long running examples. Trade off is slightly more resources; so can revisit later if issue. {F1982168077} Reviewed By: dulinriley Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
980f3bd to
08d7e7c
Compare
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 22, 2025
Summary:
- Ensure `cargo test -p monarch_rdma` runs on OSS CI
- Break out new testing infra into its own runner (see rationale below).
- `cargo test` in general will work for repo, but we have a lot of broken tests to resolve.
Given test suites getting relatively large and different paths (ie. cargo test vs pytest/pyright), which was actually helpful since some flakiness within python path having some long running examples. Trade off is slightly more resources; so can revisit later if issue.
{F1982168077}
Reviewed By: dulinriley
Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
08d7e7c to
d69fb12
Compare
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
dstaay-fb
added a commit
to dstaay-fb/monarch
that referenced
this pull request
Sep 22, 2025
Summary:
- Ensure `cargo test -p monarch_rdma` runs on OSS CI
- Break out new testing infra into its own runner (see rationale below).
- `cargo test` in general will work for repo, but we have a lot of broken tests to resolve.
Given test suites getting relatively large and different paths (ie. cargo test vs pytest/pyright), which was actually helpful since some flakiness within python path having some long running examples. Trade off is slightly more resources; so can revisit later if issue.
{F1982168077}
Reviewed By: dulinriley
Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
d69fb12 to
59d7269
Compare
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
Summary:
- Ensure `cargo test -p monarch_rdma` runs on OSS CI
- Break out new testing infra into its own runner (see rationale below).
- `cargo test` in general will work for repo, but we have a lot of broken tests to resolve.
Given test suites getting relatively large and different paths (ie. cargo test vs pytest/pyright), which was actually helpful since some flakiness within python path having some long running examples. Trade off is slightly more resources; so can revisit later if issue.
{F1982168077}
Reviewed By: dulinriley
Differential Revision: D82699014
dstaay-fb
force-pushed
the
export-D82699014
branch
from
59d7269 to
65e58ca
Compare
|
@dstaay-fb has exported this pull request. If you are a Meta employee, you can view the originating diff in D82699014. |
|
This pull request has been merged in 265034a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Ensure
cargo test -p monarch_rdmaruns on OSS CIDifferential Revision: D82699014