Add casting support to resource::GetState messages #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating diff in D82687236. |
Summary: Part of: meta-pytorch#1209 Use casting to implement the `supervision_events` API instead of iterating over all ProcMeshAgents. This will scale better as the size of the ProcMesh increases. This requires making some trait bound changes to `resource::GetState` so that it can be casted with. Unfortunately, the Actor name for the mesh agent is not compatible with the v1::Name struct due to the missing uuid. Make `v1::Name` an enum to allow reserved names to be used for things like ActorMeshes. Also, minor improvement: make ActorMeshRef::supervision_events not take a Name, we can assume it is for the current mesh's name. Differential Revision: D82687236
dulinriley
force-pushed
the
export-D82687236
branch
from
9b5532f to
45d2f0e
Compare
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating diff in D82687236. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Part of: #1209
Use casting to implement the
supervision_eventsAPI instead of iterating over allProcMeshAgents. This will scale better as the size of the ProcMesh increases.
This requires making some trait bound changes to
resource::GetStateso that it can be casted with.Unfortunately, the Actor name for the mesh agent is not compatible with the v1::Name struct
due to the missing uuid. Make
v1::Namean enum to allow reserved names to be used forthings like ActorMeshes.
Also, minor improvement: make ActorMeshRef::supervision_events not take a Name, we can assume
it is for the current mesh's name.
Differential Revision: D82687236