-
Notifications
You must be signed in to change notification settings - Fork 105
[hyperactor] factor net into modules
#1831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mariusae
wants to merge
5
commits into
gh/mariusae/133/base
Choose a base branch
from
gh/mariusae/133/head
base: gh/mariusae/133/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,950
−1,834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a straightforward refactor of `net` into `net::server` and `net::client`. More to come. Differential Revision: [D86800094](https://our.internmc.facebook.com/intern/diff/D86800094/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86800094/)! [ghstack-poisoned]
This was referenced Nov 11, 2025
mariusae
added a commit
that referenced
this pull request
Nov 11, 2025
This is a straightforward refactor of `net` into `net::server` and `net::client`. More to come. Differential Revision: [D86800094](https://our.internmc.facebook.com/intern/diff/D86800094/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86800094/)! ghstack-source-id: 322528492 Pull Request resolved: #1831
This is a straightforward refactor of `net` into `net::server` and `net::client`. More to come. Differential Revision: [D86800094](https://our.internmc.facebook.com/intern/diff/D86800094/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86800094/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 12, 2025
Pull Request resolved: #1831 This is a straightforward refactor of `net` into `net::server` and `net::client`. More to come. Differential Revision: [D86800094](https://our.internmc.facebook.com/intern/diff/D86800094/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86800094/)! ghstack-source-id: 322612894
This is a straightforward refactor of `net` into `net::server` and `net::client`. More to come. Differential Revision: [D86800094](https://our.internmc.facebook.com/intern/diff/D86800094/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86800094/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 12, 2025
Pull Request resolved: #1831 This is a straightforward refactor of `net` into `net::server` and `net::client`. More to come. ghstack-source-id: 322615744 Differential Revision: [D86800094](https://our.internmc.facebook.com/intern/diff/D86800094/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86800094/)!
This is a straightforward refactor of `net` into `net::server` and `net::client`. More to come. Differential Revision: [D86800094](https://our.internmc.facebook.com/intern/diff/D86800094/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86800094/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 12, 2025
Pull Request resolved: #1831 This is a straightforward refactor of `net` into `net::server` and `net::client`. More to come. ghstack-source-id: 322729924 Differential Revision: [D86800094](https://our.internmc.facebook.com/intern/diff/D86800094/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86800094/)!
This is a straightforward refactor of `net` into `net::server` and `net::client`. More to come. Differential Revision: [D86800094](https://our.internmc.facebook.com/intern/diff/D86800094/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86800094/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 12, 2025
Pull Request resolved: #1831 This is a straightforward refactor of `net` into `net::server` and `net::client`. More to come. ghstack-source-id: 322824633 Differential Revision: [D86800094](https://our.internmc.facebook.com/intern/diff/D86800094/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86800094/)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
netinto modules #1831This is a straightforward refactor of
netintonet::serverandnet::client. More to come.Differential Revision: D86800094
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!