Enale buck testing in ET for llm runner #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
mergennachin
force-pushed
the
buck_build_oss
branch
from
960d662 to
a773845
Compare
mergennachin
requested review from
larryliu0820,
jackzhxng,
GregoryComer and
lucylq
mergennachin
changed the title
GregoryComer
approved these changes
Sep 23, 2025
|
@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83076906. |
|
Is a BUCK file also required for xplat? And, why is TARGETS required for the test? :0 |
Summary: I want to run these tests in ET OSS buck test: ``` buck2 build //extension/llm/runner:text_decoder_runner buck2 build //extension/llm/runner:multimodal_runner_lib ``` However, tokenizer has a missing TARGETS file. It has targets.bzl but not TARGETS Reviewed By: GregoryComer Differential Revision: D83076906 Pulled By: mergennachin
facebook-github-bot
force-pushed
the
buck_build_oss
branch
from
a773845 to
54c5b39
Compare
|
@mergennachin has exported this pull request. If you are a Meta employee, you can view the originating diff in D83076906. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to run these tests in ET OSS buck test:
However, tokenizer has a missing TARGETS file. It has targets.bzl but not TARGETS