Use CUDA 13.0 on CI #862
Closed
Use CUDA 13.0 on CI #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
commented
Sep 2, 2025
.github/workflows/docs.yaml
Outdated
| # PR. | ||
| python-version: ['3.10'] | ||
| cuda-version: ['12.6'] | ||
| cuda-version: ['12.8'] |
There was a problem hiding this comment.
Drive-by, 12.6 is still supported but the "default" CUDA version supported by pytorch is currently 12.8
There was a problem hiding this comment.
Its possible that the github runner linux.4xlarge.nvidia.gpu does not have CUDA 12.8, and thats why this job was erroring. I've reverted it since its not related to this change, but we could leave a TODO to update the CUDA version if its something we need to change eventually.
NicolasHug
commented
Sep 30, 2025
| if sys.platform == "linux": | ||
| if args[0].device.type == "cuda": | ||
| atol = 2 | ||
| atol = 3 |
There was a problem hiding this comment.
I think we should be able to preserve the previous stricter with CUDA < 13 with something like:
Suggested change
| atol = 3 | |
| atol = 3 if cuda_version_used_for_building_torch() >= (13, 0) else 2 |
|
Thanks @Dan-Flores for the fixes! LGTM, let's close this one so you can open a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems from https://github.com/pytorch/torchcodec/actions/runs/17402821403/job/49401670135?pr=831 that test-infra stopped support 12.9 and is generating jobs for 13.0 instead, so we need to change our jobs to reflect that.