Add TLX attention (WS pipelined pingpong hopper) #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njriasan
reviewed
Aug 12, 2025
| q, k, v, self.causal, self.sm_scale, "tma" | ||
| ) | ||
|
|
||
| @register_benchmark(enabled=HAS_TLX) |
There was a problem hiding this comment.
Is the intention to run on CI? If you just want to trigger this test directly you can do with enabled=False and without any risk of it running on hardware you don't expect (e.g. MI300), which it will by default right now.
|
|
||
| import triton | ||
| import triton.language as tl | ||
| import triton.language.extra.tlx as tlx |
There was a problem hiding this comment.
I'm assuming we have tested this doesn't crash without tlx because of the guards in the operator.py file.
xuzhao9
reviewed
Sep 5, 2025
| HAS_XFORMERS = False | ||
|
|
||
| # [Optional] TLX backend | ||
| try: |
There was a problem hiding this comment.
We introduced a cleaner version of the guards in #387. This can be simplified to
Suggested change
| try: | |
| from tritonbench.utils.python_utils import try_import | |
| with try_import("HAS_TLX"): | |
| import triton.language.extra.tlx as tlx | |
| from .tlx_attn_ws_pipelined_pingpong_hopper import ( | |
| attention as tlx_attn_ws_pipelined_pingpong_hopper, | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.