Add amax as default per-row scaling factor for fp8_gemm benchmark #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D80590746 |
jananisriram
added a commit
to jananisriram/tritonbench
that referenced
this pull request
Aug 20, 2025
…ta-pytorch#341) Summary: Add `amax` (absolute maximum) as the default scaling factor for per-row scaling for fp8 GEMMs, as is used in practice. Reviewed By: NikhilAPatel Differential Revision: D80590746
jananisriram
force-pushed
the
export-D80590746
branch
from
01177cd to
9ee2e8e
Compare
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D80590746 |
jananisriram
added a commit
to jananisriram/tritonbench
that referenced
this pull request
Aug 20, 2025
…ta-pytorch#341) Summary: Add `amax` (absolute maximum) as the default scaling factor for per-row scaling for fp8 GEMMs, as is used in practice. Reviewed By: NikhilAPatel Differential Revision: D80590746
jananisriram
force-pushed
the
export-D80590746
branch
from
9ee2e8e to
d676989
Compare
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
added a commit
to jananisriram/tritonbench
that referenced
this pull request
Aug 20, 2025
…ta-pytorch#341) Summary: Add `amax` (absolute maximum) as the default scaling factor for per-row scaling for fp8 GEMMs, as is used in practice. Reviewed By: NikhilAPatel Differential Revision: D80590746
jananisriram
force-pushed
the
export-D80590746
branch
from
d676989 to
eac3b24
Compare
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D80590746 |
NikhilAPatel
approved these changes
Aug 20, 2025
|
This pull request was exported from Phabricator. Differential Revision: D80590746 |
jananisriram
added a commit
to jananisriram/tritonbench
that referenced
this pull request
Aug 20, 2025
…ta-pytorch#341) Summary: Pull Request resolved: meta-pytorch#341 Add `amax` (absolute maximum) as the default scaling factor for per-row scaling for fp8 GEMMs, as is used in practice. Reviewed By: NikhilAPatel Differential Revision: D80590746
jananisriram
force-pushed
the
export-D80590746
branch
from
eac3b24 to
72d907c
Compare
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
jananisriram
force-pushed
the
export-D80590746
branch
from
72d907c to
b48289d
Compare
jananisriram
added a commit
to jananisriram/tritonbench
that referenced
this pull request
Aug 20, 2025
…ta-pytorch#341) Summary: Add `amax` (absolute maximum) as the default scaling factor for per-row scaling for fp8 GEMMs, as is used in practice. Reviewed By: NikhilAPatel Differential Revision: D80590746
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D80590746 |
jananisriram
added a commit
to jananisriram/tritonbench
that referenced
this pull request
Aug 22, 2025
…ta-pytorch#341) Summary: Pull Request resolved: meta-pytorch#341 Add `amax` (absolute maximum) as the default scaling factor for per-row scaling for fp8 GEMMs, as is used in practice. Reviewed By: NikhilAPatel, xuzhao9 Differential Revision: D80590746
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D80590746 |
jananisriram
added a commit
to jananisriram/tritonbench
that referenced
this pull request
Aug 22, 2025
…ta-pytorch#341) Summary: Pull Request resolved: meta-pytorch#341 Add `amax` (absolute maximum) as the default scaling factor for per-row scaling for fp8 GEMMs, as is used in practice. Reviewed By: NikhilAPatel, xuzhao9 Differential Revision: D80590746
jananisriram
force-pushed
the
export-D80590746
branch
from
207889e to
bb8cbe8
Compare
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request was exported from Phabricator. Differential Revision: D80590746 |
jananisriram
force-pushed
the
export-D80590746
branch
from
bb8cbe8 to
221d375
Compare
jananisriram
added a commit
to jananisriram/tritonbench
that referenced
this pull request
Aug 22, 2025
…ta-pytorch#341) Summary: Pull Request resolved: meta-pytorch#341 Add `amax` (absolute maximum) as the default scaling factor for per-row scaling for fp8 GEMMs, as is used in practice. Reviewed By: NikhilAPatel, xuzhao9 Differential Revision: D80590746
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D80590746 |
jananisriram
added a commit
to jananisriram/tritonbench
that referenced
this pull request
Aug 22, 2025
…ta-pytorch#341) Summary: Pull Request resolved: meta-pytorch#341 Add `amax` (absolute maximum) as the default scaling factor for per-row scaling for fp8 GEMMs, as is used in practice. Reviewed By: NikhilAPatel, xuzhao9 Differential Revision: D80590746
jananisriram
force-pushed
the
export-D80590746
branch
from
221d375 to
78559a2
Compare
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@jananisriram has imported this pull request. If you are a Meta employee, you can view this in D80590746. |
…ta-pytorch#341) Summary: Add `amax` (absolute maximum) as the default scaling factor for per-row scaling for fp8 GEMMs, as is used in practice. Reviewed By: xuzhao9 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Differential Revision: D80590746 Pulled By: jananisriram
jananisriram
force-pushed
the
export-D80590746
branch
from
199f881 to
69edf00
Compare
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request was exported from Phabricator. Differential Revision: D80590746 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
Summary: Add `amax` (absolute maximum) as the default scaling factor for per-row scaling for fp8 GEMMs, as is used in practice. Reviewed By: xuzhao9 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Differential Revision: D80590746 Pulled By: jananisriram
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add
amax(absolute maximum) as the default scaling factor for per-row scaling for fp8 GEMMs, as is used in practice.Reviewed By: NikhilAPatel
Differential Revision: D80590746