feat/db-backend-wasm #389

SersemPeca · 2025-10-03T14:09:34Z

This PR introduces a new abstraction over our communication layer and some new types for working with DAP.

(EDIT: an initial version of virtualized filesystem for the wasm case implemented in #400 by @SersemPeca : and merged into this PR as well)

resolving part of #339 (TODO #340)

TODOS: (alexander: in future PR-s):

Use compression in wasm build

src/db-backend/src/dap_server.rs

src/db-backend/build.sh

alehander92 · 2025-10-06T15:46:16Z

src/db-backend/src/c_compat.rs

@@ -0,0 +1,280 @@
+#[cfg(feature = "browser-transport")]


is the rust/c compat code copied from existing compat layers/manually written or generated?

Most of it is copied from already existing shims, we do have a couple of functions which I had to implement myself though

src/db-backend/src/trace_processor.rs

src/db-backend/tests/dap_backend_server.rs

alehander92 · 2025-10-06T15:52:27Z

src/db-backend/wasm-sysroot/include/wctype.h

@@ -0,0 +1,171 @@
+#ifndef TREE_SITTER_WASM_WCTYPE_H_


are all those C/treesitter/sysroot files manual/custom, if not, what license are they, do they need attribution?

These are glibc header files

alehander92

looks good, a few notes

alehander92 · 2025-10-07T09:17:21Z

PS: rust clippy fixes!

reo101 · 2025-10-10T10:37:33Z

src/db-backend/src/transport.rs

+
+    impl DapTransport for BrowserTransport {
+        fn send(&mut self, msg: &DapMessage) -> Result<(), DapError> {
+            // 2) OR send as string (simpler, but pick one path)


Suggested change

// 2) OR send as string (simpler, but pick one path)

reo101 · 2025-10-10T10:42:11Z

src/db-backend/src/dap.rs

        Some("response") => Ok(DapMessage::Response(serde_json::from_value(value)?)),
        Some("event") => Ok(DapMessage::Event(serde_json::from_value(value)?)),
-        _ => Err(serde_json::Error::custom("Unknown DAP message type")),
+        _ => Err(serde_json::Error::custom("Unknown DAP message type"))?,


Suggested change

_ => Err(serde_json::Error::custom("Unknown DAP message type"))?,

_ => Err(serde_json::Error::custom("Unknown DAP message type")),

reo101 · 2025-10-10T10:56:54Z

src/db-backend/src/dap_server.rs

+// fn forward_raw_events<W: Write>(
+//     rx: &mpsc::Receiver<BackendResponse>,
+//     writer: &mut W,
+//     seq: &mut i64,
+// ) -> Result<(), Box<dyn Error>> {
+//     while let Ok(BackendResponse::EventResponse((kind, _id, payload, raw))) = rx.try_recv() {
+//         if raw && matches!(kind, EventKind::MissingEventKind) {
+//             if let Ok(DapMessage::Event(mut ev)) = dap::from_json(&payload) {
+//                 ev.base.seq = *seq;
+//                 *seq += 1;
+//                 dap::write_message(writer, &DapMessage::Event(ev))?;
+//             }
+//         }
+//     }
+//     Ok(())
+// }
+


Suggested change

// fn forward_raw_events<W: Write>(

// rx: &mpsc::Receiver<BackendResponse>,

// writer: &mut W,

// seq: &mut i64,

// ) -> Result<(), Box<dyn Error>> {

// while let Ok(BackendResponse::EventResponse((kind, _id, payload, raw))) = rx.try_recv() {

// if raw && matches!(kind, EventKind::MissingEventKind) {

// if let Ok(DapMessage::Event(mut ev)) = dap::from_json(&payload) {

// ev.base.seq = *seq;

// *seq += 1;

// dap::write_message(writer, &DapMessage::Event(ev))?;

// }

// }

// }

// Ok(())

// }

reo101 · 2025-10-10T10:58:01Z

src/db-backend/src/dap_server.rs

+// pub fn run_stdio() -> Result<(), Box<dyn Error>> {
+//     let stdin = std::io::stdin();
+//     let stdout = std::io::stdout();
+//     let mut reader = BufReader::new(stdin.lock());
+//     let mut writer = stdout.lock();
+//     handle_client(&mut reader, &mut writer)
+// }
+


Suggested change

// pub fn run_stdio() -> Result<(), Box<dyn Error>> {

// let stdin = std::io::stdin();

// let stdout = std::io::stdout();

// let mut reader = BufReader::new(stdin.lock());

// let mut writer = stdout.lock();

// handle_client(&mut reader, &mut writer)

// }

reo101 · 2025-10-10T11:01:04Z

src/db-backend/src/dap_server.rs

    // duration code copied from
    // https://rust-lang-nursery.github.io/rust-cookbook/datetime/duration.html
-    let start = Instant::now();
+    let _start = Instant::now();


Suggested change

let _start = Instant::now();

reo101 · 2025-10-10T11:16:49Z

src/db-backend/wasm-sysroot/include/endian.h

+#define le32toh(x) (x)
+#define le64toh(x) (x)
+
+


Suggested change

reo101 · 2025-10-10T11:19:10Z

src/db-backend/wasm-testing/index.js

+let blq = () => {
+  console.log(":(((((");
+  console.log("Sending message", req);
+  worker.postMessage(req);
+}
+
+(async () => { await workerPromise; blq() })()


reo101 · 2025-10-10T11:20:07Z

src/db-backend/Cargo.toml

+# CPPFLAGS_wasm32_unknown_unknown = "--target=wasm32 --sysroot={cwd}/wasm-sysroot -isystem {cwd}/wasm-sysroot/include"
+# CFLAGS_wasm32_unknown_unknown = "-I{cwd}/wasm-sysroot/include -DNDEBUG -Wbad-function-cast -Wcast-function-type -fno-builtin"
+


Suggested change

# CPPFLAGS_wasm32_unknown_unknown = "--target=wasm32 --sysroot={cwd}/wasm-sysroot -isystem {cwd}/wasm-sysroot/include"

# CFLAGS_wasm32_unknown_unknown = "-I{cwd}/wasm-sysroot/include -DNDEBUG -Wbad-function-cast -Wcast-function-type -fno-builtin"

reo101 · 2025-10-10T11:20:29Z

nix/shells/main.nix

-      rustup
+      binaryen
+      llvmPackages_21.clang-unwrapped
+      # clang


Suggested change

# clang

reo101 · 2025-10-10T11:20:38Z

nix/shells/main.nix

+
+    export CPPFLAGS_wasm32_unknown_unknown="--target=wasm32 --sysroot=$(pwd)/src/db-backend/wasm-sysroot -isystem $(pwd)/src/db-backend/wasm-sysroot/include"
+    export CFLAGS_wasm32_unknown_unknown="-I$(pwd)/src/db-backend/wasm-sysroot/include -DNDEBUG -Wbad-function-cast -Wcast-function-type -fno-builtin"
+


Suggested change

export CPPFLAGS_wasm32_unknown_unknown="--target=wasm32 --sysroot=$(pwd)/src/db-backend/wasm-sysroot -isystem $(pwd)/src/db-backend/wasm-sysroot/include"

export CFLAGS_wasm32_unknown_unknown="-I$(pwd)/src/db-backend/wasm-sysroot/include -DNDEBUG -Wbad-function-cast -Wcast-function-type -fno-builtin"

export CPPFLAGS_wasm32_unknown_unknown="--target=wasm32 --sysroot=$(pwd)/src/db-backend/wasm-sysroot -isystem $(pwd)/src/db-backend/wasm-sysroot/include"

export CFLAGS_wasm32_unknown_unknown="-I$(pwd)/src/db-backend/wasm-sysroot/include -DNDEBUG -Wbad-function-cast -Wcast-function-type -fno-builtin"

The build script will later be translated into a build.rs

…sktop mode

…ing to separate dir

alehander92

great: thank you!

SersemPeca requested review from Ro6afF and alehander92 October 3, 2025 14:09

SersemPeca changed the title ~~feat/db-backend-wasm~~ DRAFT:feat/db-backend-wasm Oct 3, 2025

alehander92 assigned SersemPeca Oct 3, 2025

alehander92 added enhancement New feature or request refactor A system was refactored db-backend wasm dap protocol labels Oct 3, 2025

alehander92 added this to the Stylus Milestone 4 milestone Oct 3, 2025

alehander92 reviewed Oct 3, 2025

View reviewed changes

src/db-backend/src/dap_server.rs Outdated Show resolved Hide resolved

SersemPeca requested a review from reo101 October 4, 2025 09:09

SersemPeca force-pushed the feat/db-backend-wasm-poc branch from b243289 to 066265e Compare October 6, 2025 11:51

SersemPeca changed the title ~~DRAFT:feat/db-backend-wasm~~ feat/db-backend-wasm Oct 6, 2025

SersemPeca force-pushed the feat/db-backend-wasm-poc branch from 79aafc8 to b47de00 Compare October 6, 2025 15:12

alehander92 reviewed Oct 6, 2025

View reviewed changes

src/db-backend/build.sh Outdated Show resolved Hide resolved

alehander92 reviewed Oct 6, 2025

View reviewed changes

src/db-backend/src/trace_processor.rs Outdated Show resolved Hide resolved

alehander92 reviewed Oct 6, 2025

View reviewed changes

src/db-backend/tests/dap_backend_server.rs Outdated Show resolved Hide resolved

alehander92 reviewed Oct 6, 2025

View reviewed changes

SersemPeca force-pushed the feat/db-backend-wasm-poc branch 5 times, most recently from e2d9228 to 58c139b Compare October 7, 2025 15:23

reo101 reviewed Oct 10, 2025

View reviewed changes

SersemPeca added 2 commits October 13, 2025 14:47

WIP: begin work on db-backend-wasm crate

0ae0f2a

feat: clean up the two crates

6d3f21f

SersemPeca added 18 commits October 13, 2025 14:48

feat: Finalize transport layer implementation

2e0a3bb

feat(wasm): Add a wasm-sysroot and a build script for the wasm target

ef4f36a

The build script will later be translated into a build.rs

feat(wasm): Add some more functions to the c shim

52d6313

feat(wasm): Add some more c functions to link against for wasm

cc3f128

fix: Stop deleting backend-manager assigned socket when running in de…

6fd01fe

…sktop mode

feat: Add needed env vars for building ts grammars; Extract wasm test…

6e28975

…ing to separate dir

feat: Add cargo aliases for native and asm builds

4b93343

chore: Remove debug info! statements

4cb06f1

chore: Clean up Cargo.toml

c742271

chore: Clean up

39482dd

feat: Finalize building the db-backend for wasm

bdad5fa

fix: Fix tests

748dedb

fix: Address PR comments

406bd81

fix: Remove dead code from small-lang

15c7377

feat: Add initial in-memory filesystem for wasm build

07a2237

fix: Fix tests and apply some stylistic code changes

784027a

feat: Update LICENSE to mention wasm-sysroot origins

111836b

chore: Make clippy happy

4665e4d

SersemPeca force-pushed the feat/db-backend-wasm-poc branch from 236237c to 4665e4d Compare October 13, 2025 12:07

alehander92 approved these changes Oct 13, 2025

View reviewed changes

chore: Address miscellaneous changes

92f8764

alehander92 merged commit ed610cf into main Oct 13, 2025
7 checks passed

alehander92 deleted the feat/db-backend-wasm-poc branch October 13, 2025 12:36

github-actions bot locked and limited conversation to collaborators Oct 13, 2025

	_ => Err(serde_json::Error::custom("Unknown DAP message type"))?,
	_ => Err(serde_json::Error::custom("Unknown DAP message type")),

		# CPPFLAGS_wasm32_unknown_unknown = "--target=wasm32 --sysroot={cwd}/wasm-sysroot -isystem {cwd}/wasm-sysroot/include"
		# CFLAGS_wasm32_unknown_unknown = "-I{cwd}/wasm-sysroot/include -DNDEBUG -Wbad-function-cast -Wcast-function-type -fno-builtin"


		export CPPFLAGS_wasm32_unknown_unknown="--target=wasm32 --sysroot=$(pwd)/src/db-backend/wasm-sysroot -isystem $(pwd)/src/db-backend/wasm-sysroot/include"
		export CFLAGS_wasm32_unknown_unknown="-I$(pwd)/src/db-backend/wasm-sysroot/include -DNDEBUG -Wbad-function-cast -Wcast-function-type -fno-builtin"

Uh oh!

feat/db-backend-wasm #389

feat/db-backend-wasm #389

Uh oh!

Conversation

SersemPeca commented Oct 3, 2025 • edited by alehander92 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alehander92 Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alehander92 left a comment

Choose a reason for hiding this comment

Uh oh!

alehander92 commented Oct 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alehander92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SersemPeca commented Oct 3, 2025 •

edited by alehander92

Loading

alehander92 Oct 6, 2025 •

edited

Loading