Consider options for cached history. #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Okay. This is great. I'll take this. |
Contributor
Author
|
#14 is a bigger and more sophisticated issue which could happen on top of this. My simple change just fixes the issue that you cannot use the local history when you want to use sort or filter together with a limit. That's why I think this small change has value on its own. |
Member
|
Yes it is. That's why I like to take this in. |
arunoda
added a commit
that referenced
this pull request
Jul 23, 2015
Consider options for cached history.
|
hi guys...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using the options parameter to pass filter and sort parameter for the search. If combined with a limit this returns incorrect results, when the search term (query) stays the same, but the filter or sort parameters are changed, since this doesn't trigger a new search on the server. To fix this I stringify the options and add them to the query to use as history key.