- 
                Notifications
    You must be signed in to change notification settings 
- Fork 19
          add selection
          #13
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            Amerlander
  wants to merge
  14
  commits into
  metonym:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
Amerlander:selection
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    
  
    add selection
  
  #13
                      Changes from 5 commits
      Commits
    
    
            Show all changes
          
          
            14 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      f80db4e
              
                Merge pull request #2 from metonym/master
              
              
                Amerlander ba3bdbd
              
                Merge pull request #3 from Amerlander/master
              
              
                Amerlander 1f558b9
              
                Introduce `selection`-function and `active`-class
              
              
                Amerlander ad14cc6
              
                Update Typeahead.d.ts
              
              
                Amerlander 8ae1947
              
                reove `!important` from css
              
              
                Amerlander 3ee7b6e
              
                Prevent disabled items from beeing selected
              
              
                Amerlander 3b67075
              
                Update Typeahead.svelte
              
              
                Amerlander 1e365b8
              
                Update Typeahead.svelte
              
              
                Amerlander 9c619f2
              
                Update Typeahead.svelte
              
              
                Amerlander 0edd3eb
              
                Update Typeahead.svelte
              
              
                Amerlander e573e89
              
                Update Typeahead.svelte
              
              
                Amerlander f1e522f
              
                Update Typeahead.svelte
              
              
                Amerlander 4258381
              
                update readme
              
              
                 9ed60c9
              
                Update Readme
              
              
                 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not keen on using a border for the active state. It causes the text of an active item to shift. I'd prefer keeping the existing style of using a background color to distinguish the active but not selected state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, what about this blue: #d8e9f3
