Remove once_cell dep by replacing once_cell::sync::OnceCell with std::sync::OnceLock
#116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://doc.rust-lang.org/std/sync/struct.OnceLock.html was introduced in rust 1.70.0 which falls within this projects MSRV of 1.70.0 (according to the github actions config)
As such we can just replace the usage of OnceCell with OnceLock to remove the once_cell dependency.
There were some tests using
once_cell::sync::Lazyin what appears to be an attempt to prevent race conditions in concurrently running tests.However, this does not help as I still observed test failures locally and needed to set
--test-threads 1. (In fact CI is setup to run--test-threads 1anyway)So I opted to just remove this usage entirely.
If the usage in tests was important, I am happy to do one of: