Skip to content

fix: updating server_address on local and adding depdency comment #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

fix: updating server_address on local and adding depdency comment #50

wants to merge 2 commits into from

Conversation

@thomasyopes
Copy link

@thomasyopes thomasyopes commented Apr 26, 2024 •
edited
Loading

Ref: #1719

Description

  • Adjusted local url to match current .env API URL value (currently http://127.0.0.1)
  • Added dependency comment noting that editing the server_address requires editing the proxy string replace function

Release Plan

  • Merge this

@thomasyopes thomasyopes mentioned this pull request Apr 26, 2024
Merged
4 tasks
leite08
leite08 reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@leite08 leite08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion on comment below. The main thing is to point this to develop and later create a release PR (pointing to master).

src/main/resources/application-local.yaml Outdated
### enable to set the Server URL
server_address: https://localhost:8080/oauth/fhir
# ******* IMPORTANT *******
# Adjusting server_address requires updating the proxy string replace function in the API Project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to add at least the filename so its easier to find it: fhir-r4-proxy.ts

or relative path within OSS: packages/api/src/routes/medical/fhir-r4-proxy.ts

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@thomasyopes thomasyopes changed the base branch from master to develop April 30, 2024 16:51
@thomasyopes thomasyopes requested a review from leite08 April 30, 2024 16:52
@thomasyopes thomasyopes marked this pull request as draft April 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo is a code owner

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 is a code owner

@RamilGaripov RamilGaripov Awaiting requested review from RamilGaripov RamilGaripov is a code owner

@jonahkaye jonahkaye Awaiting requested review from jonahkaye

@leite08 leite08 Awaiting requested review from leite08 leite08 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomasyopes @leite08